[U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for non-DM SPL

[Chuanhua Han]

> -----Original Message-----
> From: Lukasz Majewski <lukma at denx.de>
> Sent: 2019年8月14日 18:53
> To: Chuanhua Han <chuanhua.han at nxp.com>
> Cc: Jagan Teki <jagan at amarulasolutions.com>; Xiaowei Bao
> <xiaowei.bao at nxp.com>; U-Boot-Denx <u-boot at lists.denx.de>; Pan Jiafei
> <Jiafei.Pan at freescale.com>; Jagan Teki <jagan at openedev.com>; Ruchika
> Gupta <ruchika.gupta at nxp.com>
> Subject: Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI DM flash for
> non-DM SPL
> 
> On Wed, 14 Aug 2019 10:41:32 +0000
> Chuanhua Han <chuanhua.han at nxp.com> wrote:
> 
> > > -----Original Message-----
> > > From: Lukasz Majewski <lukma at denx.de>
> > > Sent: 2019年8月14日 16:57
> > > To: Chuanhua Han <chuanhua.han at nxp.com>
> > > Cc: Jagan Teki <jagan at amarulasolutions.com>; Xiaowei Bao
> > > <xiaowei.bao at nxp.com>; U-Boot-Denx <u-boot at lists.denx.de>; Pan
> > > Jiafei <Jiafei.Pan at freescale.com>; Jagan Teki <jagan at openedev.com>;
> > > Ruchika Gupta <ruchika.gupta at nxp.com>
> > > Subject: Re: [U-Boot] [EXT] Re: [PATCH v4 1/5] spl: dm: disable SPI
> > > DM flash for non-DM SPL
> > >
> > > Hi Chuanhua,
> > >
> > > > > -----Original Message-----
> > > > > From: Jagan Teki <jagan at amarulasolutions.com>
> > > > > Sent: 2019年8月14日 15:45
> > > > > To: Chuanhua Han <chuanhua.han at nxp.com>
> > > > > Cc: Wolfgang Denk <wd at denx.de>; Shengzhou Liu
> > > > > <shengzhou.liu at nxp.com>; Ruchika Gupta <ruchika.gupta at nxp.com>;
> > > > > Jagan Teki <jagan at openedev.com>; Simon Glass <sjg at chromium.org>;
> > > > > Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>; U-Boot-Denx
> > > > > <u-boot at lists.denx.de>; Pan Jiafei <Jiafei.Pan at freescale.com>
> > > > > Subject: [EXT] Re: [U-Boot] [PATCH v4 1/5] spl: dm: disable SPI
> > > > > DM flash for non-DM SPL
> > > > >
> > > > > Caution: EXT Email
> > > > >
> > > > > On Fri, Jun 21, 2019 at 7:51 AM Chuanhua Han
> > > > > <chuanhua.han at nxp.com> wrote:
> > > > > >
> > > > > > This patch solves the problem that spiboot cannot be performed
> > > > > > in non-DM SPL.
> > > > > >
> > > > > > Signed-off-by: Pan Jiafei <Jiafei.Pan at freescale.com>
> > > > > > Signed-off-by: Chuanhua Han <chuanhua.han at nxp.com>
> > > > > > ---
> > > > > > Changes in v4:
> > > > > >         - No change.
> > > > > > Changes in v3:
> > > > > >         - Add a cover-letter for this patch set.
> > > > > > Changes in v2:
> > > > > >         - No change.
> > > > > >
> > > > > >  include/config_uncmd_spl.h | 1 +
> > > > > >  1 file changed, 1 insertion(+)
> > > > > >
> > > > > > diff --git a/include/config_uncmd_spl.h
> > > > > > b/include/config_uncmd_spl.h index c2f9735ce7..da94b3d9df
> > > > > > 100644 --- a/include/config_uncmd_spl.h
> > > > > > +++ b/include/config_uncmd_spl.h
> > > > > > @@ -15,6 +15,7 @@
> > > > > >  #undef CONFIG_DM_GPIO
> > > > > >  #undef CONFIG_DM_I2C
> > > > > >  #undef CONFIG_DM_SPI
> > > > > > +#undef CONFIG_DM_SPI_FLASH
> > > > >
> > > > > Have you made any Travis-CI run?
> > > > I tested it with a local board
> > >
> > > Could you be so kind and also test following patchset (parts from
> > > Layerscape also needs testing):
> > > https://patchwork.ozlabs.org/cover/1146494/
> > I don't quite understand this patch. How can I test it?
> 
> You need to apply it first to -master branch.
> 
> Then apply your board code (or if it is already in mainline just remove
> the #undef(s) from include/config_uncmd_spl.h)
> 
> As a last step - run make menuconfig and enable SPL_DM_SPI* flags.
Currently, it is in the master, and SPI* in the #undef(s) from include/ uncmd_spl.h has been deleted, but an error was reported:
CC      spl/lib/display_options.o
drivers/spi/spi.c: In function 'spi_do_alloc_slave':
drivers/spi/spi.c:34:8: error: 'struct spi_slave' has no member named 'bus'
   slave->bus = bus;
        ^~
drivers/spi/spi.c:35:8: error: 'struct spi_slave' has no member named 'cs'
   slave->cs = cs;
        ^~
make[3]: *** [spl/drivers/spi/spi.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [spl/drivers/spi] Error 2
make[1]: *** [spl/drivers] Error 2
make[1]: *** Waiting for unfinished jobs....
  LD      spl/lib/built-in.o
make: *** [spl/u-boot-spl] Error 2

Do I need to modify a lot of files?
> 
> > >
> > > Which allows removal of
> > > #undef CONFIG_DM_SPI
> > > #undef CONFIG_DM_SPI_FLASH
> > >
> > > and have the same configuration done via Kconfig ?
> >
> > >
> > > > _______________________________________________
> > > > U-Boot mailing list
> > > > U-Boot at lists.denx.de
> > > > https://lists.denx.de/listinfo/u-boot
> > >
> > >
> > >
> > > Best regards,
> > >
> > > Lukasz Majewski
> > >
> > > --
> > >
> > > DENX Software Engineering GmbH,      Managing Director: Wolfgang
> > > Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > > Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> > > lukma at denx.de
> 
> 
> 
> Best regards,
> 
> Lukasz Majewski
> 
> --
> 
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email:
> lukma at denx.de