[U-Boot] [RESEND PATCH v2] dm: serial: Handle "stdout-path" with ":options" correctly

Bin Meng bmeng.cn at gmail.com
Mon Dec 2 02:47:25 CET 2019


Hi Simon,

On Mon, Nov 25, 2019 at 9:52 PM Bin Meng <bmeng.cn at gmail.com> wrote:
>
> With commit f0921f5098d8 ("fdt: Sync up to the latest libfdt"),
> SiFive Unleashed board does not boot any more. This was due to
> the U-Boot local changes commit 77d7fff8cec2 ("fdt: Fix handling
> of paths with options in them") to libfdt/fdt_ro.c was dropped
> during the libfdt upgrade.
>
> From the history [1] it was mentioned that the U-Boot changes
> commit 77d7fff8cec2 ("fdt: Fix handling of paths with options in
> them") was rejected by libfdt upstream, hence we need find another
> way to fix the things.
>
> This commit uses another method, by updating serial_check_stdout()
> directly to handle the situation of "stdout-path" with ":options".
> A simpler way is to change the logic in fdtdec_get_chosen_node()
> to do similar thing, but I feel that not every property in chosen
> node may have the option in them, hence it would make more sense
> to do the special handling in serial_check_stdout() directly.
>
> [1]: http://patchwork.ozlabs.org/patch/462756/
>
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> ---
>
> Changes in v2:
> - initialize node with -1 at the beginning of serial_check_stdout()
>   for better readability
>
>  drivers/serial/serial-uclass.c | 36 +++++++++++++++++++-----------------
>  1 file changed, 19 insertions(+), 17 deletions(-)
>

Could you pull this for v2020.01 as it is a critical fix to make
SiFive FU540 board boot again?

Regards,
Bin


More information about the U-Boot mailing list