[PATCH v5 006/101] net: Move the checksum functions to lib/

Bin Meng bmeng.cn at gmail.com
Thu Dec 5 05:50:41 CET 2019


Hi Simon,

On Thu, Dec 5, 2019 at 12:28 PM Simon Glass <sjg at chromium.org> wrote:
>
> Hi Bin,
>
> On Mon, 25 Nov 2019 at 08:11, Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> > Hi Simon,
> >
> > On Mon, Nov 25, 2019 at 12:11 PM Simon Glass <sjg at chromium.org> wrote:
> > >
> > > These functions are used by code outside the network support, so move them
> > > to lib/ to be more accessible.
> > >
> > > Without this, the functions are only accessible if CONFIG_NET is defined.
> >
> > I still don't understand this. net/checksum.c is built unconditionally
> > and is not controlled by CONFIG_NET.
>
> The net/ subdir is built unconditionally for U-Boot but not for SPL
> and TPL. So if we want this function without networking, we must move
> it.
>

Thanks. I guess we will need a clearer commit message :)

Regards,
Bin


More information about the U-Boot mailing list