[U-Boot] [PATCH v2 1/1] net: avoid address-of-packed-member error

[Tom Rini]

On Thu, Dec 05, 2019 at 08:16:15AM +0100, Heinrich Schuchardt wrote:
> On 11/6/19 12:07 AM, Joe Hershberger wrote:
> > On Tue, Nov 5, 2019 at 5:49 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> > > 
> > > sandbox_defconfig does not compile using GCC 9.2.1:
> > > 
> > > net/net.c: In function ‘net_process_received_packet’:
> > > net/net.c:1288:23: error: taking address of packed member of ‘struct
> > > ip_udp_hdr’ may result in an unaligned pointer value
> > > [-Werror=address-of-packed-member]
> > >   1288 |    sumptr = (ushort *)&(ip->udp_src);
> > >        |                       ^~~~~~~~~~~~~~
> > > 
> > > Avoid the error by using a u8 pointer instead of an u16 pointer and
> > > in-lining ntohs().
> > 
> > Seems reasonable.
> > 
> > > Simplify the checksumming of the last message byte.
> > > 
> > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > 
> > Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> > 
> 
> Hello Joe,
> 
> this patch did not yet make it into
> https://gitlab.denx.de/u-boot/custodians/u-boot-net/commits/master
> 
> Is there something that needs to be changed?

And perhaps we need to split the net PR in to bug fixes to get now and
stuff to put in to -next, for the next window?  Or is this one of the
changes that causes size overflow?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191205/8ee0fcb3/attachment.sig>