[PATCH v5 099/101] x86: apl: Add FSP structures

[Simon Glass]

Hi Bin,

On Mon, 2 Dec 2019 at 00:38, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Mon, Nov 25, 2019 at 12:12 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > These are mostly specific to a particular SoC. Add the definitions for
> > Apollo Lake.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > Changes in v5: None
> > Changes in v4:
> > - apollolake -> Apollo Lake
> >
> > Changes in v3:
> > - Add VBT signature
> > - Add structures for FSP-S also
> > - Drop struct fsp_usp_header as it is now in the API file
> >
> > Changes in v2: None
> >
> >  .../asm/arch-apollolake/fsp/fsp_configs.h     |  14 +
> >  .../asm/arch-apollolake/fsp/fsp_m_upd.h       | 123 ++++++++
> >  .../asm/arch-apollolake/fsp/fsp_s_upd.h       | 292 ++++++++++++++++++
> >  .../include/asm/arch-apollolake/fsp/fsp_vpd.h |  11 +
> >  4 files changed, 440 insertions(+)
> >  create mode 100644 arch/x86/include/asm/arch-apollolake/fsp/fsp_configs.h
> >  create mode 100644 arch/x86/include/asm/arch-apollolake/fsp/fsp_m_upd.h
> >  create mode 100644 arch/x86/include/asm/arch-apollolake/fsp/fsp_s_upd.h
> >  create mode 100644 arch/x86/include/asm/arch-apollolake/fsp/fsp_vpd.h
> >
[..]

> > diff --git a/arch/x86/include/asm/arch-apollolake/fsp/fsp_vpd.h b/arch/x86/include/asm/arch-apollolake/fsp/fsp_vpd.h
> > new file mode 100644
> > index 0000000000..b14f28b236
> > --- /dev/null
> > +++ b/arch/x86/include/asm/arch-apollolake/fsp/fsp_vpd.h
> > @@ -0,0 +1,11 @@
> > +/* SPDX-License-Identifier: Intel */
> > +/*
> > + * Copyright 2019 Google LLC
> > + */
> > +
> > +#ifndef __FSP_VPD_H
> > +#define __FSP_VPD_H
> > +
> > +/* Nothing to declare here for FSP2 */
>
> Could we remove this header file completely if it's not required by FSP2?

It is used by fsp_arch.h which is common to FSP1 and FSP2. So I keep
it here for consistency.

Regards,
Simon