[U-Boot] [PATCH] spl: fix entry_point equal to load_addr

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Fri Dec 6 13:58:46 CET 2019


On Fri, Dec 6, 2019 at 1:46 PM Patrice CHOTARD <patrice.chotard at st.com> wrote:
>
> Hi
>
> This patch is breaking the STM32MP15 basic boot (spl => u-boot).

Looking at socfpga gen5 u-boot.img, this is probably broken as well.

And I don't even see any RB or TB tags here :-(

Regards,
Simon

>
> I will send a fix proposal.
>
> Thanks
>
> Patrice
>
> On 12/5/19 11:09 PM, Tom Rini wrote:
> > On Mon, Nov 25, 2019 at 05:18:20PM +0100, Giulio Benetti wrote:
> >
> >> At the moment entry_point is set to image_get_load(header) that sets it
> >> to "load address" instead of "entry point", assuming entry_point is
> >> equal to load_addr, but it's not true. Then load_addr is set to
> >> "entry_point - header_size", but this is wrong too since load_addr is
> >> not an entry point.
> >>
> >> So use image_get_ep() for entry_point assignment and image_get_load()
> >> for load_addr assignment.
> >>
> >> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
> > Applied to u-boot/master, thanks!
> >


More information about the U-Boot mailing list