[PATCH v6 086/102] x86: apl: Add pinctrl driver

Bin Meng bmeng.cn at gmail.com
Sun Dec 8 09:10:54 CET 2019


Hi Simon,

On Sat, Dec 7, 2019 at 12:54 PM Simon Glass <sjg at chromium.org> wrote:
>
> Add a driver for the Apollo Lake pinctrl. This mostly makes use of the
> common Intel pinctrl support.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v6: None

It looks the comment in v5 was not addressed. See
https://lists.denx.de/pipermail/u-boot/2019-December/392375.html

> Changes in v5: None
> Changes in v4:
> - Allow pinctrl nodes to have subnodes (i.e. GPIO nodes)
> - Drop GPIO_NUM_PAD_CFG_REGS
> - Switch over to use pinctrl for pad init/config
> - Tidy up the header file a little
> - apollolake -> Apollo Lake
>
> Changes in v3:
> - Add various minor tidy-ups
> - Fix mixed case in GPIO defines
> - Rework how pads configuration is defined in TPL and SPL
> - Use the IRQ uclass instead of ITSS
>
> Changes in v2: None
>
>  arch/x86/include/asm/arch-apollolake/gpio.h | 490 ++++++++++++++++++++
>  drivers/pinctrl/intel/Kconfig               |   8 +
>  drivers/pinctrl/intel/Makefile              |   1 +
>  drivers/pinctrl/intel/pinctrl_apl.c         | 192 ++++++++
>  4 files changed, 691 insertions(+)
>  create mode 100644 arch/x86/include/asm/arch-apollolake/gpio.h
>  create mode 100644 drivers/pinctrl/intel/pinctrl_apl.c
>

Regards,
Bin


More information about the U-Boot mailing list