[PATCH v6 091/102] x86: apl: Add LPC driver

Bin Meng bmeng.cn at gmail.com
Sun Dec 8 09:24:40 CET 2019


On Sat, Dec 7, 2019 at 12:54 PM Simon Glass <sjg at chromium.org> wrote:
>
> This driver the LPC and provides a few functions to set up LPC features.
> These should probably use ioctls() or perhaps, better, have specific
> uclass methods.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v6:
> - Drop init of ComB since it is not used
> - Drop lpc_configure_pads() and probe() function, add a comment about pads
>
> Changes in v5: None
> Changes in v4:
> - Add comments for exported functions
> - Tidy up header guards
> - Use 'Apollo Lake'
> - Use BIT() macro a bit more
> - Use tabs instead of spaces
>
> Changes in v3:
> - Drop unused code in lpc_configure_pads()
> - Fix value of LPC_BC_LE
>
> Changes in v2: None
>
>  arch/x86/cpu/apollolake/Makefile           |   1 +
>  arch/x86/cpu/apollolake/lpc.c              | 122 +++++++++++++++++++++
>  arch/x86/include/asm/arch-apollolake/lpc.h |  82 ++++++++++++++
>  3 files changed, 205 insertions(+)
>  create mode 100644 arch/x86/cpu/apollolake/lpc.c
>  create mode 100644 arch/x86/include/asm/arch-apollolake/lpc.h
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list