[PATCH] cmd/eeprom.c: prepend 0x to hex numbers in output message format

Lukasz Majewski lukma at denx.de
Wed Dec 11 13:21:25 CET 2019


On Wed, 11 Dec 2019 11:18:29 +0000
Rasmus Villemoes <rasmus.villemoes at prevas.dk> wrote:

> From: "Klaus H. Sorensen" <khso at prevas.dk>
> 
> If the numbers do not happen to contain any digits from [a-f], it's
> not clear that they are base 16.
> 
> Signed-off-by: Klaus H. Sorensen <khso at prevas.dk>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> ---
>  cmd/eeprom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmd/eeprom.c b/cmd/eeprom.c
> index 19953df082..23d9a21ab6 100644
> --- a/cmd/eeprom.c
> +++ b/cmd/eeprom.c
> @@ -307,7 +307,7 @@ static int eeprom_execute_command(enum
> eeprom_action action, int i2c_bus, {
>  	int rcode = 0;
>  	const char *const fmt =
> -		"\nEEPROM @0x%lX %s: addr %08lx  off %04lx  count
> %ld ... ";
> +		"\nEEPROM @0x%lX %s: addr 0x%08lx  off 0x%04lx
> count %ld ... "; #ifdef CONFIG_CMD_EEPROM_LAYOUT
>  	struct eeprom_layout layout;
>  #endif

Reviewed-by: Lukasz Majewski <lukma at denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191211/a4bdfe03/attachment.sig>


More information about the U-Boot mailing list