[PATCH 16/35] common: Move type declarations to linux/types.h

Heinrich Schuchardt xypron.glpk at gmx.de
Thu Dec 12 09:19:38 CET 2019


On 12/12/19 1:47 AM, Simon Glass wrote:
> This file already has lots of type declarations so it seems better to put
> all of them there.

It seems you missed these patches:

merged patch:
https://lists.denx.de/pipermail/u-boot/2019-December/393191.html
linux/types.h: fix typo unchar

reviewed but not merged:
https://lists.denx.de/pipermail/u-boot/2019-December/393509.html
common: remove duplicate typedef for uchar

Best regards

Heinrich

>
> Move them.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>   include/common.h      | 5 -----
>   include/linux/types.h | 5 +++++
>   2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/common.h b/include/common.h
> index 7bb18c572e..4ee14f78d0 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -15,11 +15,6 @@
>
>   #ifndef __ASSEMBLY__		/* put C only stuff in this section */
>
> -typedef unsigned char		uchar;
> -typedef volatile unsigned long	vu_long;
> -typedef volatile unsigned short vu_short;
> -typedef volatile unsigned char	vu_char;
> -
>   #include <config.h>
>   #include <errno.h>
>   #include <time.h>
> diff --git a/include/linux/types.h b/include/linux/types.h
> index bd912bcb42..78dfa14ae8 100644
> --- a/include/linux/types.h
> +++ b/include/linux/types.h
> @@ -163,4 +163,9 @@ struct ustat {
>   #define DECLARE_BITMAP(name, bits) \
>   	unsigned long name[BITS_TO_LONGS(bits)]
>
> +typedef unsigned char uchar;
> +typedef volatile unsigned long	vu_long;
> +typedef volatile unsigned short vu_short;
> +typedef volatile unsigned char	vu_char;
> +
>   #endif /* _LINUX_TYPES_H */
>



More information about the U-Boot mailing list