[PATCH 07/35] common: Move functions for loading from fat/ext2 to fs.h

Tom Rini trini at konsulko.com
Thu Dec 12 15:10:39 CET 2019


On Thu, Dec 12, 2019 at 09:31:08AM +0100, Heinrich Schuchardt wrote:
> On 12/12/19 1:47 AM, Simon Glass wrote:
> > These are filesystem functions and belong in the filesystem header file.
> > Move them.
> 
> I am not very fond of having any file system dependencies outside of
> disk/ and part/.
> 
> Do we need the functions do_ext2load() and do_fat_fsload() at all?
> 
> What is the benefit of the file system parameter in the sysboot command?

A patch to make CMD_SYSBOOT depend on CMD_FS_GENERIC and see if everyone
is already doing that would be good.  Implementation-wise it's going to
be fat/ext2/tftp.

> Why have a restriction to ext2 in board/inversepath/usbarmory/usbarmory.c?

Intended usage only maybe?  I'll let Andrej chime in here.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191212/4c833eb4/attachment.sig>


More information about the U-Boot mailing list