[PATCH 25/35] image: Rename load_addr, save_addr, save_size

[Tom Rini]

On Wed, Dec 11, 2019 at 05:47:44PM -0700, Simon Glass wrote:

> These global variables are quite short and generic. In fact the same name
> is more often used locally for struct members and function arguments.
> 
> Add a image_ prefix to make them easier to distinguish.

I'm not so sure about this patch:
[snip]
> diff --git a/common/image.c b/common/image.c
> index eb626dcac9..877c97839b 100644
> --- a/common/image.c
> +++ b/common/image.c
> @@ -556,9 +556,9 @@ static const image_header_t *image_get_ramdisk(ulong rd_addr, uint8_t arch,
>  /* Shared dual-format routines */
>  /*****************************************************************************/
>  #ifndef USE_HOSTCC
> -ulong load_addr = CONFIG_SYS_LOAD_ADDR;	/* Default Load Address */

It's the default safe to load whatever to address.  It's not just for
"images".  It is the generic'ist load address.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191212/26912b54/attachment.sig>