[v2 1/5] Revert "ata: fsl_ahci: Add sata DM support for Freescale powerpc socs"

Priyanka Jain priyanka.jain at nxp.com
Tue Dec 17 10:19:51 CET 2019



>-----Original Message-----
>From: Stefan Roese <sr at denx.de>
>Sent: Monday, December 2, 2019 1:29 PM
>To: Peng Ma <peng.ma at nxp.com>; Priyanka Jain <priyanka.jain at nxp.com>;
>wd at denx.de; Ruchika Gupta <ruchika.gupta at nxp.com>; Shengzhou Liu
><shengzhou.liu at nxp.com>
>Cc: Yinbo Zhu <yinbo.zhu at nxp.com>; Z.q. Hou <zhiqiang.hou at nxp.com>;
>sjg at chromium.org; jagan at openedev.com; andre.przywara at arm.com;
>smoch at web.de; Andy Tang <andy.tang at nxp.com>; u-boot at lists.denx.de
>Subject: Re: [v2 1/5] Revert "ata: fsl_ahci: Add sata DM support for Freescale
>powerpc socs"
>
>Hi Peng,
>
>On 02.12.19 04:40, Peng Ma wrote:
>> This reverts commit 1ee494291880fd51ef0c5f7342e072bdb069d7ff.
>>
>> Commit 1ee494291880 ("ata: fsl_ahci: Add sata DM support for Freescale
>> powerpc socs") introduced SCSI layer to call AHCI private API in order
>> to support sata operations, In DM mode, This is not necessary for
>> non-AHCI sata. So revert it and have already updated the driver itself
>> to operate sata directly.
>>
>> Signed-off-by: Peng Ma <peng.ma at nxp.com>
>> ---
>> Changed for v2:
>> 	- Add detailed explanation.
>
>Thanks for adding a more detailed decription here. But at first glance I still
>failed to unterstand this. What's missing is (at least for me), that you explain
>that you added a new DM enabled SATA driver to support this controller [1]
>which makes this AHCI driver superfluous.
>
>Is this explanation correct?
>
>If yes, then feel free to add my:
>
>Reviewed-by: Stefan Roese <sr at denx.de>
>
>to the complete patchset.
>
>Thanks,
>Stefan
>
<snip>
There are many merge conflicts
Kindly rebase the series to top of tree(next branch) and also add "Reviewed-by: Stefan Roese <sr at denx.de> "in all patches.

Thanks
Priyanka


More information about the U-Boot mailing list