[PATCH] ARM: stm32: Permit multiple board targets

[Marek Vasut]

On 12/18/19 2:20 PM, Patrick DELAUNAY wrote:
> Hi Marek,

Hi,

>> From: Marek Vasut <marex at denx.de>
>> Sent: mercredi 18 décembre 2019 07:59
>>
>> Setting TARGET_STM32MP1 in Kconfig always forces SYS_BOARD,
>> SYS_VENDOR and SYS_CONFIG_NAME to values set by the ST reference
>> platforms. Allow changing that by pulling out the TARGET_STM32MP157C_DK2
>> and making the ST reference platform settings conditional on
>> TARGET_STM32MP157C_DK2 .
>> Other platforms can now define a different TARGET_ and thus override the SYS_
>> settings in their Kconfig.
>>
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> Cc: Patrick Delaunay <patrick.delaunay at st.com>
>> Cc: Patrice Chotard <patrice.chotard at st.com>
>> ---
>>  board/st/stm32mp1/Kconfig | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/board/st/stm32mp1/Kconfig b/board/st/stm32mp1/Kconfig index
>> 4fa2360b4f..c84aa41f06 100644
>> --- a/board/st/stm32mp1/Kconfig
>> +++ b/board/st/stm32mp1/Kconfig
>> @@ -1,4 +1,8 @@
>> -if TARGET_STM32MP1
>> +config TARGET_STM32MP157C_DK2
>> +	bool "support of STMicroelectronics STM32MP157C-DK2 Discovery
>> Board"
>> +	default y
>> +
>> +if TARGET_STM32MP157C_DK2
>>
>>  config SYS_BOARD
>>  	default "stm32mp1"
>> @@ -22,8 +26,4 @@ config CMD_STBOARD
>>  	  This compile the stboard command to
>>  	  read and write the board in the OTP.
>>
>> -config TARGET_STM32MP157C_DK2
>> -	bool "support of STMicroelectronics STM32MP157C-DK2 Discovery
>> Board"
>> -	default y
> 
> I try to understood the issue but checked DK2 is not enought
> (I will soon introduce a new config for EV1 support)
> 
> What it the use case ?

Custom board.

> Add a new board (not a board provided by ST)  which are managed by a new directory
> 	board/<CONFIG_SYS_VENDOR>/<CONFIG_SYS_BOARD>
> 
> I think, if it is the case, we should test CONFIG_SYS_VENDOR = "stm32mp1"
> in board/st/stm32mp1/Kconfig
> 
> And move CONFIG_SYS_VENDOR to arch

Nope, SYS_VENDOR is the board manufacturer . For you it's ST, for me
it's "thus far undisclosed custom board vendor".

> NB: default value can be overidde in your board defconfig...
> 
> Normally:
> - stm32mp1_trusted_defconfig
> - stm32mp1_basic_defconfig 
> - stm32mp1_optee_defconfig
> 
> only support the directory ST board with board/st/stm32mp1

That's not how it's supposed to work -- these values should be defaulted
in Kconfig.