[PATCH 5/5] arm64: dts: meson: add libretech-pc support

[Neil Armstrong]

Hi,

On 20/12/2019 04:05, Chen-Yu Tsai wrote:
> On Fri, Dec 20, 2019 at 2:37 AM Jerome Brunet <jbrunet at baylibre.com> wrote:
>>
>> Add support for the Amlogic based libretech-pc platform.
>> This platform comes with 2 variant, based on the s905d or s912 SoC.
>>
>> Signed-off-by: Jerome Brunet <jbrunet at baylibre.com>
>> ---
>>  arch/arm/dts/Makefile                         |   2 +
>>  arch/arm/dts/meson-gx-libretech-pc.dtsi       | 376 ++++++++++++++++++
>>  .../meson-gxl-s905d-libretech-pc-u-boot.dtsi  |   7 +
>>  arch/arm/dts/meson-gxl-s905d-libretech-pc.dts |  17 +
>>  arch/arm/dts/meson-gxl-s905d.dtsi             |  12 +
>>  arch/arm/dts/meson-gxl.dtsi                   |  35 +-
>>  .../meson-gxm-s912-libretech-pc-u-boot.dtsi   |   7 +
>>  arch/arm/dts/meson-gxm-s912-libretech-pc.dts  |  62 +++
>>  configs/libretech-s905d-pc_defconfig          |  73 ++++
>>  configs/libretech-s912-pc_defconfig           |  73 ++++
>>  10 files changed, 654 insertions(+), 10 deletions(-)
>>  create mode 100644 arch/arm/dts/meson-gx-libretech-pc.dtsi
>>  create mode 100644 arch/arm/dts/meson-gxl-s905d-libretech-pc-u-boot.dtsi
>>  create mode 100644 arch/arm/dts/meson-gxl-s905d-libretech-pc.dts
>>  create mode 100644 arch/arm/dts/meson-gxl-s905d.dtsi
>>  create mode 100644 arch/arm/dts/meson-gxm-s912-libretech-pc-u-boot.dtsi
>>  create mode 100644 arch/arm/dts/meson-gxm-s912-libretech-pc.dts
>>  create mode 100644 configs/libretech-s905d-pc_defconfig
>>  create mode 100644 configs/libretech-s912-pc_defconfig
> 
> May I suggest including the actual model name "AML-S912-PC" in the
> file names? That will make it that much more obvious what these files
> are for, instead of "libretech-pc" which few people have heard of.
> 
> So something like "meson-libretech-aml-s912-pc.dtsi",
> "meson-gxl-s905d-libretech-aml-s912-pc.dts",
> "meson-gxm-s912-libretech-aml-s912-pc.dts",
> "libretech-aml-s912-pc-s905d_defconfig", and
> "libretech-aml-s912-pc-s912_defconfig".
> 
> Same goes for the Linux copy.

It keeps the same scheme as the libretech-ac and libretech-ac DT naming,
please comment the Linux patchset instead of this one.

Neil

> 
> ChenYu
>