[PATCH v1] Revert "core: device: use dev_power_domain_on"

[Igor Opaniuk]

Hi Peng,

On Fri, Dec 20, 2019 at 3:14 AM Peng Fan <peng.fan at nxp.com> wrote:
>
> > Subject: [PATCH v1] Revert "core: device: use dev_power_domain_on"
> >
> > From: Igor Opaniuk <igor.opaniuk at toradex.com>
> >
> > This reverts commit f0cc4eae9a1702a768817ea25d9f23cece69d021
> >
> > This was previously reported that f0cc4eae9a ("core: device:
> > use dev_power_domain_on") breaks initial boot on Colibri iMX8X and
> > IMX8 QM ROM 7720a1 board. Revert it until the problem is properly fixed.
>
> This is not the root cause. Please check your driver power domain.

There is no any statement anywhere that this is the "root cause".
Me and Oliver pointed to this commit as it was the first one when two
MX8-based boards from different vendors just stoped booting.

That is pretty obvious that there were updates also on SCFW/TF-A side, but
unfortunately I haven't found any related information (nor in the
commit message, neither any
updates in board/freescale/imx8*/README), just some notice in one of
ML threads, where
Oliver actually reported this issue.

Please provide more info about what version of SECO, SCFW and TF-A using.

Thanks

>
> Thanks
> Peng.
>
> >
> > Signed-off-by: Igor Opaniuk <igor.opaniuk at toradex.com>
> > ---
> >
> >  drivers/core/device.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/core/device.c b/drivers/core/device.c index
> > 4e037083a6..c5b232c259 100644
> > --- a/drivers/core/device.c
> > +++ b/drivers/core/device.c
> > @@ -313,6 +313,7 @@ static void *alloc_priv(int size, uint flags)
> >
> >  int device_probe(struct udevice *dev)
> >  {
> > +     struct power_domain pd;
> >       const struct driver *drv;
> >       int size = 0;
> >       int ret;
> > @@ -396,9 +397,8 @@ int device_probe(struct udevice *dev)
> >       if (CONFIG_IS_ENABLED(POWER_DOMAIN) && dev->parent &&
> >           (device_get_uclass_id(dev) != UCLASS_POWER_DOMAIN) &&
> >           !(drv->flags & DM_FLAG_DEFAULT_PD_CTRL_OFF)) {
> > -             ret = dev_power_domain_on(dev);
> > -             if (ret)
> > -                     goto fail;
> > +             if (!power_domain_get(dev, &pd))
> > +                     power_domain_on(&pd);
> >       }
> >
> >       ret = uclass_pre_probe_device(dev);
> > --
> > 2.17.1
>


-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk