[v3 1/5] Revert "ata: fsl_ahci: Add sata DM support for Freescale powerpc socs"

Priyanka Jain priyanka.jain at nxp.com
Mon Dec 23 09:35:35 CET 2019


>-----Original Message-----
>From: Peng Ma <peng.ma at nxp.com>
>Sent: Tuesday, December 17, 2019 3:34 PM
>To: sjg at chromium.org; Priyanka Jain <priyanka.jain at nxp.com>; Marcel
>Ziswiler <marcel.ziswiler at toradex.com>; Andy Tang <andy.tang at nxp.com>
>Cc: u-boot at lists.denx.de; Peng Ma <peng.ma at nxp.com>
>Subject: [v3 1/5] Revert "ata: fsl_ahci: Add sata DM support for Freescale
>powerpc socs"
>
>This reverts commit 1ee494291880fd51ef0c5f7342e072bdb069d7ff.
>
>Commit 1ee494291880 ("ata: fsl_ahci: Add sata DM support for Freescale
>powerpc socs") introduced SCSI layer to call AHCI private API in order to
>support sata operations, In DM mode, This is not necessary for non-AHCI
>sata. So revert it and have already updated the driver itself to operate sata
>directly.
>
>Reviewed-by: Stefan Roese <sr at denx.de>
>Signed-off-by: Peng Ma <peng.ma at nxp.com>
>---
>Changed for v3:
>	- make rebase.
>	- add Reviewed-by.
>
> drivers/ata/Kconfig    |   10 -
> drivers/ata/Makefile   |    1 -
> drivers/ata/fsl_ahci.c | 1031 ----------------------------------------
> drivers/ata/fsl_sata.h |    1 -
> 4 files changed, 1043 deletions(-)
> delete mode 100644 drivers/ata/fsl_ahci.c
<snip>
Getting below  compilation error with this patch:
"drivers/ata/fsl_sata.c: In function init_sata:
drivers/ata/fsl_sata.c:131:6: error: fsl_sata_t {aka struct fsl_sata} has no member named dma_flag
  sata->dma_flag = fsl_sata_info[dev].flags;"
I do see a patch "ata: fsl_sata: Update fsl sata header file" later in the series which fixes this. 

But as per the process, each individual patch in series should apply cleanly and does not break compilation of existing platforms.
Re-order/merge accordingly.
Thanks
Priyanka


More information about the U-Boot mailing list