[EXT] Re: [v5 8/8] dm: arm: ls1021a: add i2c DM support

[Biwen Li]

> Caution: EXT Email
> 
> Hi Biwen,
> 
> On Thu, 19 Dec 2019 at 09:03, Biwen Li <biwen.li at nxp.com> wrote:
> >
> > This supports i2c DM and enables CONFIG_DM_I2C for SoC LS1021A
> >
> > Reviewed-by: Priyanka Jain <priyanka.jain at nxp.com>
> > Signed-off-by: Biwen Li <biwen.li at nxp.com>
> > ---
> > Changes in v5:
> >         - none
> >
> > Changes in v4:
> >         - update copyright
> >
> > Changes in v3:
> >         - none
> >
> > Changes in v2:
> >         - merge some patches to one patch
> >
> >  board/freescale/common/dcu_sii9022a.c         | 95
> +++++++++++++++++++
> >  board/freescale/common/diu_ch7301.c           | 80
> ++++++++++++++++
> >  board/freescale/ls1021aqds/dcu.c              | 44 ++++++++-
> >  board/freescale/ls1021aqds/ls1021aqds.c       | 21 +++-
> >  board/freescale/ls1021atwr/ls1021atwr.c       | 27 +++++-
> >  configs/ls1021aiot_qspi_defconfig             |  2 +
> >  configs/ls1021aiot_sdcard_defconfig           |  2 +
> >  configs/ls1021aqds_ddr4_nor_defconfig         |  2 +
> >  configs/ls1021aqds_ddr4_nor_lpuart_defconfig  |  2 +
> >  configs/ls1021aqds_nand_defconfig             |  2 +
> >  configs/ls1021aqds_nor_SECURE_BOOT_defconfig  |  2 +
> >  configs/ls1021aqds_nor_defconfig              |  2 +
> >  configs/ls1021aqds_nor_lpuart_defconfig       |  2 +
> >  configs/ls1021aqds_qspi_defconfig             |  2 +
> >  configs/ls1021aqds_sdcard_ifc_defconfig       |  2 +
> >  configs/ls1021aqds_sdcard_qspi_defconfig      |  2 +
> >  configs/ls1021atsn_qspi_defconfig             |  2 +
> >  configs/ls1021atsn_sdcard_defconfig           |  2 +
> >  configs/ls1021atwr_nor_SECURE_BOOT_defconfig  |  2 +
> >  configs/ls1021atwr_nor_defconfig              |  2 +
> >  configs/ls1021atwr_nor_lpuart_defconfig       |  2 +
> >  configs/ls1021atwr_qspi_defconfig             |  2 +
> >  ...s1021atwr_sdcard_ifc_SECURE_BOOT_defconfig |  2 +
> >  configs/ls1021atwr_sdcard_ifc_defconfig       |  2 +
> >  configs/ls1021atwr_sdcard_qspi_defconfig      |  2 +
> >  include/configs/ls1021aiot.h                  |  4 +
> >  include/configs/ls1021aqds.h                  |  3 +
> >  include/configs/ls1021atsn.h                  |  4 +-
> >  include/configs/ls1021atwr.h                  |  4 +
> >  29 files changed, 314 insertions(+), 8 deletions(-)
> >
> 
> On the LS1021A-TSN board, reading the EEPROM broke with this change.
> 
> See below boot logs with #define DEBUG put in
> board/freescale/common/sys_eeprom.c:
> 
> Before:
> 
> EEPROM: ID: NXID v1
> SN:
> Errata:
> Build date: 20ff/ff/ff 7f:ff:ff PM
> Eth0: 00:1f:7b:63:03:07
> Eth1: 00:1f:7b:63:03:2b
> Eth2: 00:1f:7b:63:03:4f
> Eth3: 00:1f:7b:63:03:4f
> Eth4: 00:1f:7b:63:03:4f
> Eth5: 00:1f:7b:63:03:4f
> Eth6: 00:1f:7b:63:03:4f
> Eth7: ff:ff:ff:ff:ff:ff
> Eth8: ff:ff:ff:ff:ff:ff
> Eth9: ff:ff:ff:ff:ff:ff
> Eth10: ff:ff:ff:ff:ff:ff
> Eth11: ff:ff:ff:ff:ff:ff
> Eth12: ff:ff:ff:ff:ff:ff
> Eth13: ff:ff:ff:ff:ff:ff
> Eth14: ff:ff:ff:ff:ff:ff
> Eth15: ff:ff:ff:ff:ff:ff
> CRC: c2eb9a5c
> EEPROM dump: (0x100 bytes)
> 00: 4E 58 49 44 FF FF FF FF FF FF FF FF FF FF FF FF
> 10: FF FF FF FF FF FF FF FF FF FF FF FF 00 00 00 01
> 20: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 30: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 40: FF FF 00 1F 7B 63 03 07 00 1F 7B 63 03 2B 00 1F
> 50: 7B 63 03 4F 00 1F 7B 63 03 4F 00 1F 7B 63 03 4F
> 60: 00 1F 7B 63 03 4F 00 1F 7B 63 03 4F FF FF FF FF
> 70: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 80: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 90: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> A0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> B0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> C0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> D0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> E0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> F0: FF FF FF FF FF FF FF FF FF FF FF FF C2 EB 9A 5C NXID v1
> 
> After:
> 
> EEPROM: ID:      v4294967295
> SN:
> Errata:
> Build date: 20ff/ff/ff 7f:ff:ff PM
> CRC: ffffffff (should be a13778d2)
> EEPROM dump: (0x100 bytes)
> 00: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 10: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 20: FF FF 00 1F 7B 63 03 07 00 1F 7B 63 03 2B 00 1F
> 30: 7B 63 03 4F 00 1F 7B 63 03 4F 00 1F 7B 63 03 4F
> 40: 00 1F 7B 63 03 4F 00 1F 7B 63 03 4F FF FF FF FF
> 50: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 60: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 70: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 80: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> 90: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> A0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> B0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> C0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> D0: FF FF FF FF FF FF FF FF FF FF FF FF C2 EB 9A 5C
> E0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
> F0: FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF Invalid ID (ff ff ff ff)
> 
> I suppose the other LS1021A boards are in a similar situation.
Hi Vladimir, thanks, I will reply you once I get the board ls1021atsn.
> 
> Thanks,
> -Vladimir