[PATCH 3/3] efi_rng_protocol: Install the efi_rng_protocol on the root node

[Heinrich Schuchardt]

On 12/24/19 4:54 PM, Sughosh Ganu wrote:
> Install the EFI_RNG_PROTOCOL implementation for it's subsequent use by
> the kernel for features like kaslr.
>
> Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> ---
>   include/efi_loader.h           | 4 ++++
>   lib/efi_loader/efi_rng.c       | 2 ++
>   lib/efi_loader/efi_root_node.c | 4 ++++
>   3 files changed, 10 insertions(+)
>
> diff --git a/include/efi_loader.h b/include/efi_loader.h
> index bec7873..71996ec 100644
> --- a/include/efi_loader.h
> +++ b/include/efi_loader.h
> @@ -130,6 +130,7 @@ extern const struct efi_hii_config_routing_protocol efi_hii_config_routing;
>   extern const struct efi_hii_config_access_protocol efi_hii_config_access;
>   extern const struct efi_hii_database_protocol efi_hii_database;
>   extern const struct efi_hii_string_protocol efi_hii_string;
> +extern const struct efi_rng_protocol efi_rng_protocol_ops;

Could we, please, call this variable efi_rng_protocol.

Otherwise

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

>
>   uint16_t *efi_dp_str(struct efi_device_path *dp);
>
> @@ -175,6 +176,9 @@ extern const efi_guid_t efi_guid_hii_config_access_protocol;
>   extern const efi_guid_t efi_guid_hii_database_protocol;
>   extern const efi_guid_t efi_guid_hii_string_protocol;
>
> +/* GUID of RNG protocol */
> +extern const efi_guid_t efi_guid_rng_protocol;
> +
>   extern unsigned int __efi_runtime_start, __efi_runtime_stop;
>   extern unsigned int __efi_runtime_rel_start, __efi_runtime_rel_stop;
>
> diff --git a/lib/efi_loader/efi_rng.c b/lib/efi_loader/efi_rng.c
> index 8456592..80c8fc9 100644
> --- a/lib/efi_loader/efi_rng.c
> +++ b/lib/efi_loader/efi_rng.c
> @@ -11,6 +11,8 @@
>
>   DECLARE_GLOBAL_DATA_PTR;
>
> +const efi_guid_t efi_guid_rng_protocol = EFI_RNG_PROTOCOL_GUID;
> +
>   static efi_status_t EFIAPI rng_getinfo(struct efi_rng_protocol *this,
>   					    efi_uintn_t *rng_algo_size,
>   					    efi_rng_algorithm *rng_algo)
> diff --git a/lib/efi_loader/efi_root_node.c b/lib/efi_loader/efi_root_node.c
> index f68b0fd..3d937ce 100644
> --- a/lib/efi_loader/efi_root_node.c
> +++ b/lib/efi_loader/efi_root_node.c
> @@ -81,6 +81,10 @@ efi_status_t efi_root_node_register(void)
>   			 &efi_guid_hii_config_routing_protocol,
>   			 (void *)&efi_hii_config_routing,
>   #endif
> +#if CONFIG_IS_ENABLED(EFI_RNG_PROTOCOL)
> +			 &efi_guid_rng_protocol,
> +			 (void *)&efi_rng_protocol_ops,
> +#endif
>   			 NULL));
>   	efi_root->type = EFI_OBJECT_TYPE_U_BOOT_FIRMWARE;
>   	return ret;
>