[PATCH] tools/imximage: share DCD information via Kconfig

[Stefano Babic]

Hi Jorge, Fabio,

On 11/12/19 12:34, Fabio Estevam wrote:
> On Wed, Dec 11, 2019 at 6:42 AM Jorge Ramirez-Ortiz <jorge at foundries.io> wrote:
>>
>> IMX based platforms can have the DCD table located on different
>> addresses due to differences in their memory maps (ie iMX7ULP).
>>
>> This information is required by the user to sign the images for secure
>> boot so continue making it accessible via mkimage.
>>
>> Signed-off-by: Jorge Ramirez-Ortiz <jorge at foundries.io>
> 
> Reviewed-by: Fabio Estevam <festevam at gmail.com>
> 
> Stefano,
> 
> This is a bug fix for 2020.01.
> 

It is, but CONFIG_IMX_DCD_ADDR is then undefined for all architectures
outside i.MX (because the config does not run), while imximage.c is
always built. Then outside i.MX leads to broken build. I would at least
add in imximage a check if it is not set and set it to the default
value, like:

 #if !defined(CONFIG_IMX_DCD_ADDR)
 #define CONFIG_IMX_DCD_ADDR 0x00910000
 #endif

Regards,
Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================