[PATCH PATCH v6 13/13] spl: fit: Allow the board to tell if more images must be loaded from FIT

Simon Glass sjg at chromium.org
Mon Dec 30 02:18:35 CET 2019


On Tue, 22 Oct 2019 at 08:40, Jean-Jacques Hiblot <jjhiblot at ti.com> wrote:
>
> spl_fit_get_image_name() is used to get the names of the images that the
> SPL must load from the FIT. It relies on the content of a property present
> in the FIT. The list of images is thus statically defined in the FIT.
> With this scheme, it quickly becomes hard to manage combinations of more
> than a handful of images.
> To address this problem, give the board driver code the opportunity to
> add to the list of images. The images from the FIT property are loaded
> first, and then the board_get_fit_loadable() is called to get more image
> names.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
>
> ---
>
> Changes in v6:
> - Instead of matching a overlay by the name of it's node. Try to match it
>   first with the description, and then with the node's name. This allows
>   to use makeimg to add the overlays to u-boot.img and not use a custom
>   SPL_FIT_GENERATOR script
>
> Changes in v5:
> -reword commit log
>
> Changes in v4:
> - Use the board driver infrastructure to get the image names from the
> board code.
> - Remove a patch that passed the board name to the FIT generator. If needed
> the generator can get it from elsewhere
> - Add a fix to not load the firmware twice (once as a firmware and once as
> a loadable)
>
> Changes in v3:
> - removed the RFC prefix. This work will be needed soon by TI's AM65x
> platform. and can probably benefit other modular platforms
> - removed the last patch that provided an example of how to use this with
> on a DRA76.
> - removed the patch that made u-boot.img a symlink to u-boot.itb because
> it breaks the build of many platforms (because files required to build the
> ITB are missing)
> - removed the patch to reduce the footprint of the am335x SPL. (already
> merged)
> - Made the boot flow more permissive (don't fail immediately if an overlay
> is not present) and more verbose when an error occures
> - handle the dependencies of the FIT generation in a more generic way
> - use a dedicated kconfig option to enable the application of the overlays
> by the SPL.
>
> Changes in v2:
> - reworked board_fit_get_additionnal_images() and how it used in spl_fit.c
> - removed dtbo generation from dtso files and use .dts extension for the
>   overlays
> - add dynamic allocation usage in a separate patch
> - defconfig change for the am335x_evm
>
>  common/spl/spl_fit.c | 65 ++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 62 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

Can you add a test for this to sandbox_spl?


More information about the U-Boot mailing list