[PATCH v4 0/7] usb: kbd: implement special keys

[Simon Glass]

Hi Heinrich,

On Fri, 27 Dec 2019 at 21:54, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> On 12/28/19 3:26 AM, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Fri, 27 Dec 2019 at 11:21, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
> >>
> >> On 12/27/19 5:41 PM, Simon Glass wrote:
> >>> Hi,
> >>>
> >>> On Sat, 23 Nov 2019 at 13:05, Marek Vasut <marex at denx.de> wrote:
> >>>>
> >>>> On 11/23/19 6:15 PM, Heinrich Schuchardt wrote:
> >>>>> GRUB uses function keys. So we should support these with an USB keyboard.
> >>>>> Provide support for F1-F12, Insert, Delete, Home, End, Page Up, Page Down.
> >>>>> Simplify the code beforehand.
> >>>>>
> >>>>> Enhance the keyboard unit test.
> >>>>>
> >>>>> In total I could not see any increase of u-boot.img on the TBS2910 but
> >>>>> as the special keys are only needed in the context of the UEFI subsystem
> >>>>> it makes sense to save several hundred bytes on other boards.
> >>>>
> >>>> Applied all to usb/next, thanks, so let's see what CI has to say.
> >>>
> >>> I notice that pressing F1 at the prompt now shows P and then pressing
> >>> backspace a few times makes a bit of a mess. If U-Boot itself doesn't
> >>> understand these keys, could they be ignored?
> >>
> >> Hello Simon,
> >>
> >> Thanks for reporting your test results. Could you, please, describe your
> >> scenario in detail.
> >>
> >> Was USB_KEYBOARD_FN_KEYS enabled?
> >> Which output device did you use?
> >
> > I ran U-Boot sandbox with -D and then pressed F1, followed by a few
> > backspaces, on the command line. I did not change any options.
>
> The same behavior can be seen with v2019.10.
>
> `./u-boot -D` uses sandbox_serial_getc() and not the USB driver as you
> can verify by putting a breakpoint here and into usb_kbd_put_queue(). So
> your observation seems to be unrelated to the patch series.
>
> If you want to test the USB driver, you have to emulate USB keyboard
> strokes.

OK I see, thanks. I misunderstood the effect of this series I think.

Regards,
Simon