[PATCH v6 6/8] configs: sandbox: Enable random number generator(rng) device

[Simon Glass]

Hi,

On Sat, 28 Dec 2019 at 06:21, Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> On 12/28/19 12:07 PM, Sughosh Ganu wrote:
> >
> > On Sat, 28 Dec 2019 at 11:55, Heinrich Schuchardt <xypron.glpk at gmx.de
> > <mailto:xypron.glpk at gmx.de>> wrote:
> >
> >     On 12/27/19 3:23 PM, Sughosh Ganu wrote:
> >      > Enable support for random number generator on sandbox configs.
> >     This is
> >      > aimed primarily at adding unit test support for rng uclass.
> >      >
> >      > Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org
> >     <mailto:sughosh.ganu at linaro.org>>
> >      > Reviewed-by: Patrice Chotard <patrice.chotard at st.com
> >     <mailto:patrice.chotard at st.com>>
> >      > Reviewed-by: Patrick Delaunay <patrick.delaunay at st.com
> >     <mailto:patrick.delaunay at st.com>>
> >
> >     Why do you exclude:
> >
> >     * configs/sandbox_flattree_defconfig,
> >     * configs/sandbox_spl_defconfig?
> >
> >
> > This was primarily aimed at adding a unit test for rng on a 32 bit and
> > 64 bit target. Do you think adding support for rng on the two additional
> > targets is adding any value. I don't have a strong opinion on this. If
> > you think that i should enable rng on the two additional targets as
> > well, i will do so.
> >
> > Also, can you also review the patch for adding efi_rng_protocol support
> > on qemu arm64 platform[1]. Once you have, i will make the changes and
> > send  the updated version.
> >
> > -sughosh
>
> I think we should add the RNT device to all configs so that we can test
> in any of the contexts. But is nothing that would stop me from accepting
> the patch series. We can add this later too.

I don't really mind either way. But sandbox_flattree and sandbox_spl
are there to check specific things:

sandbox_flattree - checks operation without live device tree
sandbox_spl - checks a few SPL-related things

They are often excluded when new options are added.

Regards,
Simon