[PATCH v2 1/1] travis-ci: provide env__efi_fit_tftp_file

[Stephen Warren]

On 12/30/19 12:05 PM, Heinrich Schuchardt wrote:
> On 12/30/19 5:38 PM, Stephen Warren wrote:
>> On 12/30/19 3:52 AM, Heinrich Schuchardt wrote:
>>> Provide dictionary env__efi_fit_tftp_file describing the file used for
>>> the
>>> UEFI FIT image test.
>>
>>> diff --git a/py/travis-ci/travis_tftp.py b/py/travis-ci/travis_tftp.py
>>
>>> +def efifit2env(addr=None):
>>> +    """Create dictionary describing file for EFI fit image test
>>> +
>>> +    @addr:      address used for loading the file as int (e.g.
>>> 0x40400000)
>>> +    Return:     dictionary describing the file with entries
>>> +                * fn    - filename
>>> +                * addr  - loading address, optional
>>> +                * dn    - tftp directory
>>> +    """
>>> +    tftp_dir = os.environ['UBOOT_TRAVIS_BUILD_DIR']
>>> +
>>> +    ret = {
>>> +        "fn": "test-efi-fit.img",
>>
>> If this function were to exist, then the filename shouldn't be
>> hard-coded; it should be a parameter.
>>
> 
> Hello Stephen,
> 
> thanks for reviewing.
> 
> This is the name of a generated file. It does not depend on the board.

What generates the file and when/why?

Generated files should generally be put into 
u_boot_console.config.persistent_data_dir, and presumably the name 
hard-coded into the test that uses it.