[PATCH 3/3] riscv: sifive: fu540: add SPL configuration

Amit Tomer amittomer25 at gmail.com
Tue Dec 31 18:18:41 CET 2019


Hi Pragnesh,

Minor comments regarding coding style, see below.

> +       // Probably don't need to do this, since
> +       // all the other stuff has been happening.
> +       // But it is on the wave form.

U-boot is mostly implemented in C, we should *not* use C++ style comments(//).
is this something picked from BSP code ?

> +#include "include/ccache.h"
> +#include "include/fu540-memory-map.h"

This looks bit strange, I mean the double include above

> +// Inlining header functions in C
> +// https://stackoverflow.com/a/23699777/7433423

This could be conveyed in comments rather then pointing some external
link.

Thanks
-Amit.


More information about the U-Boot mailing list