[PATCH] arm: dts: bcm283x: Allow UARTs to work before relocation

Simon Glass sjg at chromium.org
Tue Dec 31 22:28:19 CET 2019


Hi Matthias,

On Tue, 10 Dec 2019 at 02:43, Matthias Brugger <mbrugger at suse.com> wrote:
>
> Hi Simon,
>
> On 02/12/2019 16:45, Tom Rini wrote:
> > On Sun, Dec 01, 2019 at 07:33:56PM -0700, Simon Glass wrote:
> >
> >> At present the pinctrl nodes are not enabled in pre-relocation U-Boot so
> >> the UARTs do not correctly select the pinconfig to enable the UART pins.
> >> Fix this so that the U-Boot banner is printed.
> >>
> >> Signed-off-by: Simon Glass <sjg at chromium.org>
> >> Fixes: 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)
> >> ---
> >>
> >>  arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++
> >>  1 file changed, 8 insertions(+)
> >>
> >> diff --git a/arch/arm/dts/bcm283x-u-boot.dtsi b/arch/arm/dts/bcm283x-u-boot.dtsi
> >> index 36548dad62..68d03627f4 100644
> >> --- a/arch/arm/dts/bcm283x-u-boot.dtsi
> >> +++ b/arch/arm/dts/bcm283x-u-boot.dtsi
> >> @@ -19,3 +19,11 @@
> >>  &gpio {
> >>      u-boot,dm-pre-reloc;
> >>  };
> >> +
> >> +&uart0_gpio14 {
> >> +    u-boot,dm-pre-reloc;
> >> +};
> >> +
> >> +&uart1_gpio14 {
> >> +    u-boot,dm-pre-reloc;
> >> +};
> >
> > I think this is superseded by the RPi PR that I had been testing and
> > just now pushed.  Can you confirm that master is fine on your Pis as
> > well?  I gather you hit this failure doing pytest on the board, which is
> > also how I found it.  Thanks!
> >
>
> Can you confirm if this is working with master branch or if we still need your
> patch. In which situation would we need your patch then?

Unfortunately with the 'next' branch I still need this patch. WIthout
it I don't get the pre-relocation serial output and tests fail.

Regards,
Simon


More information about the U-Boot mailing list