[U-Boot] [PATCH v1 04/14] DTS: imx: Remove not needed '#address-cells' and '#size-cells' properties

Lukasz Majewski lukma at denx.de
Wed Jan 2 09:43:39 UTC 2019


Hi Marek,

> On 1/2/19 12:37 AM, Lukasz Majewski wrote:
> > This commit fixes warnings produced by newest in u-boot DTC
> > compiler: 'unnecessary #address-cells/#size-cells without "ranges"
> > or child "reg" property'
> > 
> > Signed-off-by: Lukasz Majewski <lukma at denx.de>  
> 
> I presume the DTSIs are taken from Linux, is this a backport from
> Linux then ?

Regarding Linux - with Version: DTC 1.4.7-gc86da84d and make W=1 I do
not see those warnings as in  scripts/Makefile.lib :

# Disable noisy checks by default
ifeq ($(findstring 1,$(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),)
DTC_FLAGS += -Wno-unit_address_vs_reg \
        -Wno-unit_address_format \
        -Wno-avoid_unnecessary_addr_size \

those warnings are disabled (-Wno-avoid_unnecessary_addr_size).

On the other hand - in u-boot those warnings are checked (maybe are
necessary for OF_PLATDATA correct operation?).

> 
> > ---
> > 
> >  arch/arm/dts/imx6q.dtsi   | 4 ----
> >  arch/arm/dts/imx6qdl.dtsi | 9 ---------
> >  2 files changed, 13 deletions(-)
> > 
> > diff --git a/arch/arm/dts/imx6q.dtsi b/arch/arm/dts/imx6q.dtsi
> > index c30c8368ca..7f5d91d7f0 100644
> > --- a/arch/arm/dts/imx6q.dtsi
> > +++ b/arch/arm/dts/imx6q.dtsi
> > @@ -150,8 +150,6 @@
> >  			};
> >  
> >  			ipu2_di0: port at 2 {
> > -				#address-cells = <1>;
> > -				#size-cells = <0>;
> >  				reg = <2>;
> >  
> >  				ipu2_di0_disp0: disp0-endpoint {
> > @@ -175,8 +173,6 @@
> >  			};
> >  
> >  			ipu2_di1: port at 3 {
> > -				#address-cells = <1>;
> > -				#size-cells = <0>;
> >  				reg = <3>;
> >  
> >  				ipu2_di1_hdmi: hdmi-endpoint {
> > diff --git a/arch/arm/dts/imx6qdl.dtsi b/arch/arm/dts/imx6qdl.dtsi
> > index b13b0b2db8..476cf93445 100644
> > --- a/arch/arm/dts/imx6qdl.dtsi
> > +++ b/arch/arm/dts/imx6qdl.dtsi
> > @@ -49,9 +49,6 @@
> >  	};
> >  
> >  	clocks {
> > -		#address-cells = <1>;
> > -		#size-cells = <0>;
> > -
> >  		ckil {
> >  			compatible = "fsl,imx-ckil", "fixed-clock";
> >  			#clock-cells = <0>;
> > @@ -1125,8 +1122,6 @@
> >  			};
> >  
> >  			mipi_dsi: mipi at 021e0000 {
> > -				#address-cells = <1>;
> > -				#size-cells = <0>;
> >  				reg = <0x021e0000 0x4000>;
> >  				status = "disabled";
> >  
> > @@ -1228,8 +1223,6 @@
> >  			};
> >  
> >  			ipu1_di0: port at 2 {
> > -				#address-cells = <1>;
> > -				#size-cells = <0>;
> >  				reg = <2>;
> >  
> >  				ipu1_di0_disp0: disp0-endpoint {
> > @@ -1253,8 +1246,6 @@
> >  			};
> >  
> >  			ipu1_di1: port at 3 {
> > -				#address-cells = <1>;
> > -				#size-cells = <0>;
> >  				reg = <3>;
> >  
> >  				ipu1_di1_disp1: disp1-endpoint {
> >   
> 
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190102/374d7643/attachment.sig>


More information about the U-Boot mailing list