[U-Boot] Re : Re : Re: please pull u-boot-samsung master

[Guillaume GARDET]

Hi,


----- Guillaume GARDET <guillaume.gardet at free.fr> a écrit :
> 
> Hi,
> 
> ----- Minkyu Kang <mk7.kang at samsung.com> a écrit :
> > Dear Guillaume GARDET,
> > 
> > On 28/12/18 00:41, Tom Rini wrote:
> > > On Thu, Dec 27, 2018 at 12:49:53PM +0900, Minkyu Kang wrote:
> > > 
> > >> Dear Tom,
> > >>
> > >> The following changes since commit 1f2e948d6d53f77a2ddb2dde3531b0d5bc2815ad:
> > >>
> > >>   Prepare v2019.01-rc2 (2018-12-17 20:25:24 -0500)
> > >>
> > >> are available in the git repository at:
> > >>
> > >>   git://git.denx.de/u-boot-samsung master
> > >>
> > >> for you to fetch changes up to c96d90367a6a229210b8b16681cfe9e5c8aeced1:
> > >>
> > >>   exynos: imply SYS_THUMB_BUILD (2018-12-26 11:57:48 +0900)
> > >>
> > >> ----------------------------------------------------------------
> > >> Anand Moon (2):
> > >>       exynos5-dt-types: add missing dtb file for Odroid HC1/HC2
> > >>       odroid: Update README.odroid for support of Odroid HC1
> > >>
> > >> Guillaume GARDET (1):
> > >>       exynos: imply SYS_THUMB_BUILD
> > >>
> > >> Seung-Woo Kim (1):
> > >>       Revert "arm: config: fix default console only to specify the device"
> > >>
> > >>  arch/arm/Kconfig                    | 1 +
> > >>  doc/README.odroid                   | 7 +++++--
> > >>  include/configs/odroid.h            | 4 ++--
> > >>  include/configs/odroid_xu3.h        | 5 +++--
> > >>  include/configs/s5p_goni.h          | 4 ++--
> > >>  include/configs/s5pc210_universal.h | 4 ++--
> > >>  include/configs/trats.h             | 4 ++--
> > >>  include/configs/trats2.h            | 4 ++--
> > >>  8 files changed, 19 insertions(+), 14 deletions(-)
> > > 
> > > NAK:
> > > 18: Merge branch 'master' of git://git.denx.de/u-boot-samsung
> > >        arm:  +   peach-pi smdk5420 peach-pit
> > > +(peach-pi,smdk5420,peach-pit) {standard input}: Assembler messages:
> > > +(peach-pi,smdk5420,peach-pit) {standard input}:117: Error: Thumb encoding does not support an immediate here -- `msr cpsr_c,#0x13|0xC0'
> > > +(peach-pi,smdk5420,peach-pit) {standard input}:325: Error: Thumb encoding does not support an immediate here -- `msr cpsr_c,#0x13|0xC0'
> > > +(peach-pi,smdk5420,peach-pit) make[3]: *** [../scripts/Makefile.build:279: spl/arch/arm/mach-exynos/lowlevel_init.o] Error 1
> > > +(peach-pi,smdk5420,peach-pit) make[2]: *** [../scripts/Makefile.spl:383: spl/arch/arm/mach-exynos] Error 2
> > > +(peach-pi,smdk5420,peach-pit) make[1]: *** [Makefile:1597: spl/u-boot-spl] Error 2
> > > +(peach-pi,smdk5420,peach-pit) make: *** [Makefile:148: sub-make] Error 2
> > > 
> > 
> > Because of this, thumb build feature cannot applied.
> > Do you have an idea?
> 
> We should disable thumb explicitly for this board.
> 
> I will not be in front of a computer for the next days, so please wait until 2nd of January, or you can do it, if you want.

Instead of disabling thumb for SPL in 3 default configs, I sent a patch to get it built in thumb mode: 
  https://lists.denx.de/pipermail/u-boot/2019-January/353347.html

Build tested on peach-pi peach-pit and smdk5420 configs.

Thanks,
Guillaume


> 
> Thanks,
> Guillaume
>  
> > 
> > Thanks,
> > Minkyu Kang.
>