[U-Boot] [PATCH v1 09/14] imx: serial: dm: Enable DM_FLAG_PRE_RELOC in the IMX uart driver

[Marek Vasut]

On 1/2/19 9:42 AM, Lukasz Majewski wrote:
> Hi Marek,
> 
>> On 1/2/19 12:37 AM, Lukasz Majewski wrote:
>>> The DM_FLAG_PRE_RELOC shall be enabled as this driver is going to be
>>> re-used in the i.MX based SoCs.
>>>
>>> It is crucial to have running the serial console before
>>> relocation.  
>>
>> But the patch doesn't do what the subject/commit message claims is
>> does. If I understand it correctly, it sets the PRE_RELOC flag
>> unconditionally.
> 
> The !CONFIG_IS_ENABLED(OF_CONTROL) [*] was set as a "workaround" for DM
> problem:
> SHA1: 4687919684e0e4390b9fc20d1809ecaa9dc3cb81
> 
> Let's look on this check [*] - we add this flag if the board doesn't
> support OF_CONTROL. This is a bit strange as the serial_mxc.c can be
> used with CONFIG_DM_SERIAL but without corresponding device tree
> description (OF_CONTROL).
> 
> Other boards/SoCs have this flag set unconditionally.
> 
> And one more remark - with OF_CONTROL one needs to declare
> 'u-boot,dm-pre-reloc;' property in DTS to have the device probed in the
> SPL's pre relocation stage.

Explain it in the patch description and send V2.

-- 
Best regards,
Marek Vasut