[U-Boot] [PATCH] rsa: read out public_exponent value based on 32-bit alignment

[Simon Goldschmidt]

On Fri, Jan 4, 2019 at 10:36 AM Ooi, Joyce <joyce.ooi at intel.com> wrote:
>
> > -----Original Message-----
> > From: Simon Goldschmidt [mailto:simon.k.r.goldschmidt at gmail.com]
> > Sent: Saturday, December 29, 2018 5:04 AM
> > To: Marek Vasut <marex at denx.de>; Ooi, Joyce <joyce.ooi at intel.com>; Michal
> > Simek <michal.simek at xilinx.com>; Siva Durga Prasad Paladugu
> > <siva.durga.paladugu at xilinx.com>
> > Cc: u-boot at lists.denx.de; Chee, Tien Fong <tien.fong.chee at intel.com>; See,
> > Chin Liang <chin.liang.see at intel.com>
> > Subject: Re: [U-Boot] [PATCH] rsa: read out public_exponent value based on 32-
> > bit alignment
> >
> > Am 28.12.2018 um 19:44 schrieb Marek Vasut:
> > > On 12/28/18 2:32 PM, Ooi, Joyce wrote:
> > >>> -----Original Message-----
> > >>> From: Marek Vasut [mailto:marex at denx.de]
> > >>> Sent: Friday, December 28, 2018 6:05 PM
> > >>> To: Ooi, Joyce <joyce.ooi at intel.com>; Michal Simek
> > >>> <michal.simek at xilinx.com>; Siva Durga Prasad Paladugu
> > >>> <siva.durga.paladugu at xilinx.com>
> > >>> Cc: u-boot at lists.denx.de; See, Chin Liang
> > >>> <chin.liang.see at intel.com>; Chee, Tien Fong
> > >>> <tien.fong.chee at intel.com>; Tan, Ley Foon <ley.foon.tan at intel.com>
> > >>> Subject: Re: [PATCH] rsa: read out public_exponent value based on
> > >>> 32-bit alignment
> > >>>
> > >>> On 12/28/18 8:30 AM, Ooi, Joyce wrote:
> > >>>> Hi Marek,
> > >>>
> > >>> Hi,
> > >>>
> > >>>> Any comments about this?
> > >>>
> > >>> Use get_unaligned() ?
> > >> It seems that if USE_HOSTCC is enabled, get_unaligned_* can't be used.
> > >
> > > Can this be fixed ?
> >
> > I was working on a patch (or series?) to make USE_HOSTCC more generic (i.e.
> > concentrate the HOSTCC specific things in some header files,
> > hopefully) as I have stumbled accross this when adding
> > compression/uncompression to mkimage, but I haven't found the time to
> > complete this, yet.
> >
> > Nevertheless, I think this is where we should go, rather then add yet more #ifdef
> > USE_HOSTCC to C files...
> >
> > Regards,
> > Simon
> Can you please help to fix this, Simon? I'm not too familiar with USE_HOSTCC..

I'm not there, yet, unfortunately. I don't have too much time for
U-Boot right now and my current work is getting of-platdata to run.

So it might be a few weeks until I can continue working on that.

Regards,
Simon

> Thanks.
>
> >
> > >
> > >> In lib/rsa/rsa-mod-exp.c,
> > >> #ifndef USE_HOSTCC
> > >> ..
> > >> #include <asm/unaligned.h>
> > >> #else
> > >> #include "fdt_host.h"
> > >> #include "mkimage.h"
> > >> #include <fdt_support.h>
> > >> #endif
> > >>
> > >> So, to make it more generic (with or without USE_HOSTCC enabled), I
> > >> read out the public_exponent as two 32-bit datas and then
> > >> concatenating them into a 64-bit data.
> > >
> > > See above -- I'd much rather see the get_unaligned() fixed and used.
> > >
>