[U-Boot] [PATCH] rockchip: rk3399: fix missing braces in full pinctrl

Simon Glass sjg at chromium.org
Fri Jan 4 20:43:25 UTC 2019


On Fri, 4 Jan 2019 at 11:14, Philipp Tomsich
<philipp.tomsich at theobroma-systems.com> wrote:
>
> Braces around the error-case for rk3399_pinctrl_set_pin_pupd lead to
> an unconditional (and unintended) return from the function without it
> ever setting pin-configurations.
>
> Fix it.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> ---
>
>  drivers/pinctrl/rockchip/pinctrl_rk3399.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list