[U-Boot] [PATCH v2 1/1] altera_pio: fix get_value

[Marek Vasut]

On 1/5/19 2:28 PM, Julien Béraud wrote:
> gpio_get_value should return 0 or 1, not 1 << pin

It does not return 1 << pin, it returns value of the bit & (1 << pin).
The patch is fine, reword the commit message and add my

Acked-by: Marek Vasut <marex at denx.de>

Thanks

btw you can also align the $subject tags to "gpio: altera_pio: ...".

> Signed-off-by: Julien Beraud <julien.beraud at orolia.com>
> ---
>  drivers/gpio/altera_pio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/altera_pio.c b/drivers/gpio/altera_pio.c
> index 59e30979f0..324f9c29a8 100644
> --- a/drivers/gpio/altera_pio.c
> +++ b/drivers/gpio/altera_pio.c
> @@ -56,7 +56,7 @@ static int altera_pio_get_value(struct udevice *dev, unsigned pin)
>  	struct altera_pio_platdata *plat = dev_get_platdata(dev);
>  	struct altera_pio_regs *const regs = plat->regs;
>  
> -	return readl(&regs->data) & (1 << pin);
> +	return !!(readl(&regs->data) & (1 << pin));
>  }
>  
>  
> 


-- 
Best regards,
Marek Vasut