[U-Boot] [PATCH v2 6/9] pinctrl: rockchip: Add common rockchip pinctrl driver

Heiko Stuebner heiko at sntech.de
Sat Jan 5 17:27:14 UTC 2019


Hi David,

Am Mittwoch, 2. Januar 2019, 14:00:55 CET schrieb David Wu:
> Use this driver to fit all Rockchip SOCs and to support
> the desired pinctrl configuration via DTS.
> 
> Signed-off-by: David Wu <david.wu at rock-chips.com>
> ---
> 
> Changes in v2:
> - Remove px30, rk2928, rk3066*.
> - Split it to multiple files for the relevant per-SoC data structures.

Moving so nicely close to the Linux pinctrl driver is way cool. And while
I haven't looked in that much detail, this looks nice, so

Acked-by: Heiko Stuebner <heiko at sntech.de>

Out of curiosity, why did you remove px30, rk2928 and rk3066 support?
I'm still hoping to support those at some point (someone was working
on rk3066 uboot support for example last year or so), so having the
pinctrl support already present might encourage things?
Or was that a review-request from v1?


Heiko




More information about the U-Boot mailing list