[U-Boot] [U-Boot, v2, 2/2] rockchip: fix incorrect detection of ram size

Marty E. Plummer hanetzer at startmail.com
Sun Jan 6 00:55:15 UTC 2019


On Fri, Nov 30, 2018 at 10:08:07PM +0100, Philipp Tomsich wrote:
> Marty,
> 
> > On 30.11.2018, at 22:05, Philipp Tomsich <philipp.tomsich at theobroma-systems.com> wrote:
> > 
> >> Taken from coreboot's src/soc/rockchip/rk3288/sdram.c
> >> 
> >> Without this change, my u-boot build for the asus c201 chromebook (4GiB)
> >> is incorrectly detected as 0 Bytes of ram.
> >> 
> >> Signed-off-by: Marty E. Plummer <hanetzer at startmail.com>
> >> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> >> ---
> >> arch/arm/mach-rockchip/sdram_common.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >> 
> > 
> > Applied to u-boot-rockchip, thanks!
> 
> Oops. I just had to pull this series out of the tree again...
> Didn’t realise that it hadn’t been revised, so it triggered the same build error again.
> 
Sorry, I've been a bit busy (work and school; this is a hobby until I
can turn it/something similar into a real job). I've attempted to build
the defconfig but it fails out some fdt issue I can't quite solve atm.
I'd leave it alone for now, I'm going to try fixing the issue. I may
need some help.
> When can you get an updated patch for me?
> 
As soon as I can figure out fixing 'normal' builds (without my patch)
for rk3399 I'll figure what I can do for the ram size clamp. I could
ifdef it around aarch64 or something, but that seems hacky(?), thoughts?
> Thanks,
> Philipp.
> 


More information about the U-Boot mailing list