[U-Boot] [RFC PATCH 6/8] arm: add Cubieboard7 board support

[André Przywara]

On 03/01/2019 13:26, Amit Singh Tomar wrote:

Hi,

> The Cubieboard is a single board computer containing a
> Actions S700 SoC(with 4 ARMv8 Cortex-A53 cores).
> 
> This patch adds respective defconfig alongwith device tree(sync with
> Linux 4.20).
> 
> Signed-off-by: Amit Singh Tomar <amittomer25 at gmail.com>
> ---
>  arch/arm/dts/s700-cubieboard7.dts | 39 +++++++++++++++++++++++++++++++++++++++
>  configs/cubieboard7_defconfig     | 22 ++++++++++++++++++++++
>  2 files changed, 61 insertions(+)
>  create mode 100644 arch/arm/dts/s700-cubieboard7.dts
>  create mode 100644 configs/cubieboard7_defconfig
> 
> diff --git a/arch/arm/dts/s700-cubieboard7.dts b/arch/arm/dts/s700-cubieboard7.dts
> new file mode 100644
> index 0000000..28f3f4a
> --- /dev/null
> +++ b/arch/arm/dts/s700-cubieboard7.dts
> @@ -0,0 +1,39 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2017 Andreas Färber
> + */
> +
> +/dts-v1/;
> +
> +#include "s700.dtsi"
> +
> +/ {
> +	compatible = "cubietech,cubieboard7", "actions,s700";
> +	model = "CubieBoard7";
> +
> +	aliases {
> +		serial3 = &uart3;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial3:115200n8";
> +	};
> +
> +	memory at 0 {
> +		device_type = "memory";
> +		reg = <0x0 0x0 0x0 0x80000000>;
> +	};
> +
> +	memory at 1,e0000000 {
> +		device_type = "memory";
> +		reg = <0x1 0xe0000000 0x0 0x0>;
> +	};
> +};
> +
> +&timer {
> +	clocks = <&hosc>;
> +};
> +
> +&uart3 {
> +	status = "okay";
> +};
> diff --git a/configs/cubieboard7_defconfig b/configs/cubieboard7_defconfig
> new file mode 100644
> index 0000000..f870839
> --- /dev/null
> +++ b/configs/cubieboard7_defconfig

This is copied from the Bubblegum, right?
It contains a lot of symbols that are required by the platform, so
should be tackled in the Kconfig instead of here.
This applies to the bubblegum config as well, so maybe these comments
are more for Mani ;-)

> @@ -0,0 +1,22 @@
> +CONFIG_ARM=y
> +CONFIG_ARM_SMCCC=y

Sounds like a generic OWL 64 bit requirement.

> +CONFIG_ARCH_OWL=y
> +CONFIG_SYS_TEXT_BASE=0x11000000

This is also a platform decision, to be handled generically.

> +CONFIG_MACH_S700=y
> +CONFIG_IDENT_STRING="\ncubieboard7"
> +CONFIG_DISTRO_DEFAULTS=y
> +CONFIG_NR_DRAM_BANKS=1
> +CONFIG_BOOTDELAY=5
> +CONFIG_USE_BOOTARGS=y
> +CONFIG_BOOTARGS="console=ttyOWL3,115200n8"
> +# CONFIG_DISPLAY_CPUINFO is not set
> +# CONFIG_DISPLAY_BOARDINFO is not set
> +CONFIG_SYS_PROMPT="U-Boot => "
> +CONFIG_CMD_MD5SUM=y

What is this for? If it is required by something, it should be already
selected automatically.

> +CONFIG_CMD_MEMINFO=y
> +CONFIG_CMD_CACHE=y

Why is this? Disabling the cache on the U-Boot command line sounds dodgy.

> +CONFIG_CMD_TIMER=y

Is this needed by some boot script? Then it should be set somewhere generic.


> +CONFIG_DEFAULT_DEVICE_TREE="s700-cubieboard7"
> +CONFIG_CLK=y
> +CONFIG_CLK_OWL=y
> +CONFIG_OWL_SERIAL=y

Those last three should also be set in the Kconfig.

Cheers,
Andre.