[U-Boot] [PATCH] cmd: ximg: Invert check for fit image compression

Stefan Theil stefan.theil at mixed-mode.de
Mon Jan 7 09:25:52 UTC 2019


The imgextract command runs a number of checks of
the specified fit. Where it checks for a load address
for compressed images the logic in the expression
is inverted as fit_image_check_comp returns 1 on
success and not 0.
---
 cmd/ximg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/ximg.c b/cmd/ximg.c
index 6880c747f5..8572a67a00 100644
--- a/cmd/ximg.c
+++ b/cmd/ximg.c
@@ -143,7 +143,7 @@ do_imgextract(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 			return 1;
 		}
 
-		if (fit_image_check_comp(fit_hdr, noffset, IH_COMP_NONE)
+		if (!fit_image_check_comp(fit_hdr, noffset, IH_COMP_NONE)
 		    && (argc < 4)) {
 			printf("Must specify load address for %s command "
 				"with compressed image\n",
-- 
2.17.1



More information about the U-Boot mailing list