[U-Boot] [PATCH] arm: socfpga: make debug uart work on socfpga_gen5

Marek Vasut marex at denx.de
Mon Jan 7 20:25:38 UTC 2019


On 1/7/19 9:24 PM, Simon Goldschmidt wrote:
> Am 07.01.2019 um 21:19 schrieb Marek Vasut:
>> On 1/7/19 8:36 PM, Simon Goldschmidt wrote:
>>> When debug UART is enabled on socfpga_gen5, the debug uart driver hangs
>>> in an endless loop because 'socfpga_bridges_reset' calls printf before
>>> the debug UART is initialized.
>>>
>>> After the generic fix for this in the UART driver did not work due to
>>> portability issues, let's just drop this printf statement when called
>>> from SPL with debug UART enabled.
>>>
>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
>>
>> Can we have an un-portable fix which at least works on SoCFPGA ? :)
> 
> This one worked on socfpga but broke rockchip:
> 
> https://patchwork.ozlabs.org/patch/992553/
> 
> However, the message below wasn't shown either with that patch applied.
> The code just runs too early to enable the UART.
> 
> Do you want to keep the message (although I failed to see in which
> situation it can be printed) or do you just dislike the #ifdef thing?

I'd like to keep the error message if possible. Is it possible ?

-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list