[U-Boot] [PATCH] musb-new: Hide spurious warning in interrupt

[Marek Vasut]

On 1/7/19 9:37 PM, Viktoriia Taraniuk wrote:
> During dfu command the next unnecessary warning appears:
> 
>     musb-hdrc: peripheral reset irq lost!
> 
> which confuses user (it is not an actual error).
> 
> This patch makes the warning to be printed with debug(), so
> that it only appears in debug build.

Why is it not an actual error ? This sounds like hiding real issues here.

> Signed-off-by: Viktoriia Taraniuk <viktoriia.taraniuk at globallogic.com>
> ---
>  drivers/usb/musb-new/musb_gadget_ep0.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/musb-new/musb_gadget_ep0.c b/drivers/usb/musb-new/musb_gadget_ep0.c
> index 9835a2e..0e254ac 100644
> --- a/drivers/usb/musb-new/musb_gadget_ep0.c
> +++ b/drivers/usb/musb-new/musb_gadget_ep0.c
> @@ -792,9 +792,8 @@ setup:
>  			if (unlikely(musb->g.speed == USB_SPEED_UNKNOWN)) {
>  				u8	power;
>  
> -				printk(KERN_NOTICE "%s: peripheral reset "
> -						"irq lost!\n",
> -						musb_driver_name);
> +				debug("%s: peripheral reset irq lost!\n",
> +				      musb_driver_name);
>  				power = musb_readb(mbase, MUSB_POWER);
>  				musb->g.speed = (power & MUSB_POWER_HSMODE)
>  					? USB_SPEED_HIGH : USB_SPEED_FULL;
> 


-- 
Best regards,
Marek Vasut