[U-Boot] [PATCH v2] usb: xhci-mem: Fix scratchpad array issue

[Marek Vasut]

On 1/8/19 7:34 AM, Bin Meng wrote:
> On Tue, Jan 8, 2019 at 12:00 PM Ye Li <ye.li at nxp.com> wrote:
>>
>> On 1/7/2019 5:54 PM, Bin Meng wrote:
>>> On Mon, Jan 7, 2019 at 10:45 AM Ye Li <ye.li at nxp.com> wrote:
>>>>
>>>> After updating the value of dev_context_ptrs[0], we should flush this
>>>> from cache to memory. Otherwise the xhci controller won't use it.
>>>>
>>>> Signed-off-by: Ye Li <ye.li at nxp.com>
>>>> Reviewed-by: Marek Vasut <marex at denx.de>
>>>> ---
>>>> Changes for v2:
>>>>    - Change to use sizeof(ctrl->dcbaa->dev_context_ptrs[0])
>>>>
>>>>  drivers/usb/host/xhci-mem.c | 3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>
>>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>>>
>>> But you need do the same in xhci_scratchpad_free() too. Please fix it in v3.
>>>
>> The xhci controller has been stopped before calling xhci_scratchpad_free, is it necessary to
>> add flush in this function? And I don't see other buffers are flushed when freeing.
>>
> 
> Ah, yes. It's called after HCD reset, so that's not needed.

Shall I pick this for this release then, Bin ?

-- 
Best regards,
Marek Vasut