[U-Boot] [PATCH v1 3/4] serial: add an of-platdata driver for "snps, dw-apb-uart"

[Simon Goldschmidt]

Hi Alexey,

Am 09.01.2019 um 09:35 schrieb Alexey Brodkin:
> Hi Simon,
> 
>> -----Original Message-----
>> From: Simon Goldschmidt [mailto:simon.k.r.goldschmidt at gmail.com]
>> Sent: Tuesday, January 8, 2019 12:14 AM
>> To: Marek Vasut <marex at denx.de>
>> Cc: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>; Patrice Chotard <patrice.chotard at st.com>;
>> Simon Glass <sjg at chromium.org>; Anup Patel <anup at brainfault.org>; Lokesh Vutla <lokeshvutla at ti.com>;
>> Alexey Brodkin <alexey.brodkin at synopsys.com>; Patrick Delaunay <patrick.delaunay at st.com>; Marek Vasut
>> <marek.vasut at gmail.com>; u-boot at lists.denx.de; Álvaro Fernández Rojas <noltari at gmail.com>; Ryder Lee
>> <ryder.lee at mediatek.com>; Vikas Manocha <vikas.manocha at st.com>; Alexander Graf <agraf at suse.de>; Weijie
>> Gao <weijie.gao at mediatek.com>
>> Subject: [PATCH v1 3/4] serial: add an of-platdata driver for "snps,dw-apb-uart"
>>
>> Add a driver for the "snps,dw-apb-uart" used in socfpga and others.
>>
>> This driver is required to get OF_PLATDATA to work for socfpga.
>> It uses the ns16550 driver, converting the platdata from of-platdata
>> go the ns16550 format.
>>
>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
>> ---
>>
>>   drivers/serial/Kconfig         | 10 ++++++++
>>   drivers/serial/Makefile        |  1 +
>>   drivers/serial/serial_dw_apb.c | 42 ++++++++++++++++++++++++++++++++++
>>   3 files changed, 53 insertions(+)
>>   create mode 100644 drivers/serial/serial_dw_apb.c
>>
>> diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
>> index b7ff2960ab..10addd3309 100644
>> --- a/drivers/serial/Kconfig
>> +++ b/drivers/serial/Kconfig
>> @@ -511,6 +511,16 @@ config BCM283X_PL011_SERIAL
>>   	  that supports automatic disable, so that it only gets used when
>>   	  the UART is actually muxed.
>>
>> +config DESIGNWARE_SERIAL
>> +	bool "DesignWare UART support"
>> +	depends on DM_SERIAL && SPL_OF_PLATDATA
> 
> Might be a bit naïve question but why depend on SPL_OF_PLATDATA only?
> What about CONFIG_OF_EMBED?
> 
> I'd happily switch my ARC boards on this driver and get rid of all
> CONFIG_SYS_NS16550_xxx nonsense in include/configs/myboardname.h

I checked include/configs/socfpga_common.h again and by its using 
Kconfig and DM_SERIAL, there are no CONFIG_SYS_NS16550_xxx defines left 
(other than CONFIG_SYS_NS16550_SERIAL, which I will remove).

So it seems it's not a matter of a new driver but a matter of cleaning 
up the boards to use DM_SERIAL, I guess?

Regards,
Simon