[U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly

Stefano Babic sbabic at denx.de
Thu Jan 10 09:34:21 UTC 2019


Hi Lukasz,

On 10/01/19 10:29, Lukasz Majewski wrote:
> Hi Stefano,
> 

[snip]

>> There is a topic I would like to check. Stefan introduces with his
>> patches a DDRMC_CR80_MC_INIT_COMPLETE that is still missing in your
>> patches. I solved the conflict (not yet pushed to -next) as :
>>
>> while (!(readl(&ddrmr->cr[80]) & DDRMC_CR80_MC_INIT_COMPLETE))
>>                  udelay(10);
>> writel(DDRMC_CR80_MC_INIT_COMPLETE, &ddrmr->cr[81]);
>>
>>  #ifdef CONFIG_DDRMC_VF610_CALIBRATION
>>          ddrmc_calibration(ddrmr);
>>  #endif
>>
>> But I have no idea if DDRMC_CR80_MC_INIT_COMPLETE should be done
>> before the calibration of maybe after. Could you help me ?
> 
> I've already rebased (DDR calibration code) on top of Stefan's patches:
> 
> http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=shortlog;h=refs/heads/testing
> 
> The code in question looks like in below link:
> http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=blob;f=arch/arm/mach-imx/ddrmc-vf610.c;h=9a8e2f6aad10adc45fa791d24ffad52c42c5c492;hb=refs/heads/testing#l231

ok, thanks - so the DDRMC_CR80_MC_INIT_COMPLETE is called before
calibration. I have already did this by rebasing myself. There is no
need you repost, I have merged yours patches into my -next branch.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list