[U-Boot] [PATCH v4 1/6] pinctrl: mscc: Add gpio and pinctrl for Jaguar2 SOC family

Daniel Schwierzeck daniel.schwierzeck at gmail.com
Thu Jan 10 16:56:56 UTC 2019


Hi Horatio,

Am 10.01.19 um 15:11 schrieb Gregory CLEMENT:
> Hi Horatiu,
>  
>  On jeu., janv. 10 2019, Horatiu Vultur <horatiu.vultur at microchip.com> wrote:
> 
>> The Jaguar2 SOC family has 63 gpio pins therefore I extended mscc-common
>> to support new numbe of pins and remove any platform dependency from
>> mscc-common.
>>
>> Signed-off-by: Horatiu Vultur <horatiu.vultur at microchip.com>
>> ---
>>  MAINTAINERS                           |   1 +
>>  drivers/pinctrl/mscc/Kconfig          |   9 +
>>  drivers/pinctrl/mscc/Makefile         |   1 +
>>  drivers/pinctrl/mscc/mscc-common.c    |  90 +++++++---
>>  drivers/pinctrl/mscc/mscc-common.h    |  17 +-
>>  drivers/pinctrl/mscc/pinctrl-jr2.c    | 315 ++++++++++++++++++++++++++++++++++
>>  drivers/pinctrl/mscc/pinctrl-luton.c  |  16 +-
>>  drivers/pinctrl/mscc/pinctrl-ocelot.c |  16 +-
>>  8 files changed, 436 insertions(+), 29 deletions(-)
>>  create mode 100644 drivers/pinctrl/mscc/pinctrl-jr2.c
>>

this series looks now good to me but you should address Gregory's
comments. I didn't review the device-trees in detail as I expected that
you use the Linux versions which already had a proper review.

-- 
- Daniel


More information about the U-Boot mailing list