[U-Boot] Revert "dm: pinctrl: Prevent (re-)configuring pins when already done before relocation"

Tom Rini trini at konsulko.com
Sat Jan 12 20:13:32 UTC 2019


On Wed, Jan 09, 2019 at 11:05:02PM +0100, Lukasz Majewski wrote:

> This reverts commit a7f4b4b344396590845e6552c82829ef68ef9f89.
> 
> As reported by Alex Kiernan the above optimization introduces a
> regression in the below use case where:
> 
> 1. Device has defined 'u-boot,dm-spl' property (@ eMMC DTS node)
> 
> 2. The device downloads its MLO/SPL via UART (not eMMC - the eMMC pinmux
> pins are NOT probed/configured in MLO/SPL).
> 
> 3. The loaded via UART MLO/SPL wants to load Linux from eMMC. In this case
> the DM core and pinctrl uclass checks 'u-boot,dm-spl' and don't
> configure pins (as it thinks that those were initialized in MLO/SPL).
> 
> As we are very close to release - please revert this commit.
> 
> Reported-by: Alex Kiernan <alex.kiernan at gmail.com>
> Signed-off-by: Lukasz Majewski <lukma at denx.de>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190112/34a86891/attachment.sig>


More information about the U-Boot mailing list