[U-Boot] [PATCH] fpga: zynqmp: show an error message when FPGA programming fails

[Michal Simek]

On 11. 01. 19 17:09, Luca Ceresoli wrote:
> When FPGA programming fails, it does so silently, unless debugging
> code is enabled. This makes it hard to detect problems in production
> environments.
> 
> Print the error message unconditionally so the error doesn't go
> unnoticed.
> 
> Signed-off-by: Luca Ceresoli <luca at lucaceresoli.net>
> ---
>  drivers/fpga/zynqmppl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/zynqmppl.c b/drivers/fpga/zynqmppl.c
> index c095d5ecaa85..22bfdd8dce61 100644
> --- a/drivers/fpga/zynqmppl.c
> +++ b/drivers/fpga/zynqmppl.c
> @@ -233,7 +233,7 @@ static int zynqmp_load(xilinx_desc *desc, const void *buf, size_t bsize,
>  				 (u32)bsize, 0, ret_payload);
>  
>  	if (ret)
> -		debug("PL FPGA LOAD fail\n");
> +		puts("PL FPGA LOAD fail\n");
>  
>  	return ret;
>  }
> 

Note: Not a problem with this path. It shouldn't be hard to detect it in
production system if your scripts are checking return values.

Applied.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190114/fc5c55d6/attachment.sig>