[U-Boot] [PATCH v2 2/9] ARM: rockchip: rk3188: Remove the pinctrl setup and enable uart at SPL

[David Wu]

Hi Heiko,

在 2019/1/6 上午1:17, Heiko Stuebner 写道:
>> diff --git a/arch/arm/mach-rockchip/rk3188-board-spl.c b/arch/arm/mach-rockchip/rk3188-board-spl.c
>> index 3c6c3d3c09..a5e4d39cb7 100644
>> --- a/arch/arm/mach-rockchip/rk3188-board-spl.c
>> +++ b/arch/arm/mach-rockchip/rk3188-board-spl.c
>> @@ -120,7 +120,7 @@ void board_debug_uart_init(void)
>>   
>>   void board_init_f(ulong dummy)
>>   {
>> -	struct udevice *pinctrl, *dev;
>> +	struct udevice *dev;
>>   	int ret;
>>   
>>   #define EARLY_UART
>> @@ -134,10 +134,7 @@ void board_init_f(ulong dummy)
>>   	 * printascii("string");
>>   	 */
>>   	debug_uart_init();
>> -	printch('s');
>> -	printch('p');
>> -	printch('l');
>> -	printch('\n');
>> +	printascii("U-Boot SPL board init");
> Did you test this change?
> I remember rk3188 having issues (aka hanging) when trying to print
> strings through the debug uart and only printch working at all.
> (Timer issue or so?) ... Not sure if this got fixed in the meantime?
> 

I don't know there was a issue, but i test it on the Radxa board today, 
it looks okay.

U-Boot SPL board init
U-Boot SPL 2019.01-rc1-00009-gdd7b9156fe (Jan 14 2019 - 19:53:50 +0800)
Returning to boot ROM...


U-Boot 2019.01-rc1-00009-gdd7b9156fe (Jan 14 2019 - 19:53:50 +0800)

Model: Radxa Rock
DRAM:  2 GiB
MMC:   dwmmc at 10214000: 0
Loading Environment from MMC... Card did not respond to voltage select!
*** Warning - No block device, using default environment

In:    serial at 20064000
Out:   serial at 20064000
Err:   serial at 20064000
Model: Radxa Rock
rockchip_dnl_key_pressed: adc_channel_single_shot fail!
Net:   Net Initialization Skipped
No ethernet found.
Hit any key to stop autoboot:  0
=>