[U-Boot] [PATCH v6 1/9] test: add test for lib/lmb.c

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Mon Jan 14 19:19:34 UTC 2019


Am 05.01.2019 um 02:56 schrieb Simon Glass:
> Hi Simon,
> 
> On Fri, 14 Dec 2018 at 13:14, Simon Goldschmidt
> <simon.k.r.goldschmidt at gmail.com> wrote:
>>
>> Add basic tests for the lmb memory allocation code used to reserve and
>> allocate memory during boot.
>>
>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
>> ---
>>
>> Changes in v6: None
>> Changes in v5:
>> - this patch is new in v5
>>
>> Changes in v4: None
>> Changes in v2: None
>>
>>   test/lib/Makefile |   1 +
>>   test/lib/lmb.c    | 297 ++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 298 insertions(+)
>>   create mode 100644 test/lib/lmb.c
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Seems fine. I wonder if it would be easier to simulate a 10-byte
> memory size? It shouldn't matter how big it is.

This one slipped through somehow, sorry.

I wrote the test by simulating real values. Since there is no memory 
involved, only numbers, personally, I don't think simulating 10 bytes 
makes it easier than simulating 512 MiB. I'd leave it like it is, unless 
you insist...

Regards,
Simon


More information about the U-Boot mailing list