[U-Boot] [PATCH] common: Break USB_STORAGE dependency between SPL and u-boot proper

Tom Rini trini at konsulko.com
Tue Jan 15 16:02:09 UTC 2019


On Tue, Jan 15, 2019 at 11:07:23AM +0000, Abel Vesa wrote:

> Some boards might need USB_STORAGE enabled in u-boot proper but not in SPL.
> Make a separate config for SPL and keep the same depends on conditions but for SPL.
> 
> Signed-off-by: Abel Vesa <abel.vesa at nxp.com>
> ---
>  common/Makefile                | 2 +-
>  configs/apalis_imx6_defconfig  | 1 +
>  configs/colibri_imx6_defconfig | 1 +
>  configs/mx6sabresd_defconfig   | 1 +
>  drivers/usb/Kconfig            | 8 ++++++++
>  5 files changed, 12 insertions(+), 1 deletion(-)

The root problem here, as I discovered today digging in another patch is
that in essence CONFIG_SPL_USB_SUPPORT is mis-named and should be
CONFIG_SPL_USB_STORAGE and all cases in Makefiles of
obj-$(CONFIG_USB_STORAGE) should be obj-$(CONFIG_$(SPL_)USB_STORAGE) and
common/spl/spl_usb.c have its ifdef's cleaned slightly as that code
cannot function without CONFIG_USB_STORAGE set (stor_dev will be NULL
and that _will_ oops later on).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/cb3701bd/attachment.sig>


More information about the U-Boot mailing list