[U-Boot] [U-Boot, v3] xyz-modem: Fix timeout loop waiting with WATCHDOG

Tom Rini trini at konsulko.com
Wed Jan 16 02:43:53 UTC 2019


On Tue, Jan 08, 2019 at 07:28:35PM +0530, Lokesh Vutla wrote:

> Commit 2c77c0d6524eb ("xyz-modem: Change getc timeout loop waiting")
> fixes the loop delay when using a hw watchdog, assuming that watchdog
> kicking is taken care of by getc(). But the xyzmodem driver tries to
> do a getc only after confirming that a character is available like below:
> 	while (!tstc()) {
> 		till timeout;
> 	}
> 	if (tstc())
> 		*c = getc();
> 
> and getc() does a watchdog reset only if it fails to see a character.
> In this case, getc() always sees a character and never does a
> watchdog reset. So to make sure that watchdog doesn't get reset
> while loading the file, do a watchdog reset just before starting the
> image loading.
> 
> Signed-off-by: Lokesh Vutla <lokeshvutla at ti.com>
> Signed-off-by: Vignesh R <vigneshr at ti.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/10f4d72c/attachment.sig>


More information about the U-Boot mailing list