[U-Boot] serial: ns16550: fix debug uart putc called before init

Tom Rini trini at konsulko.com
Wed Jan 16 02:44:31 UTC 2019


On Wed, Jan 09, 2019 at 08:35:31PM +0100, Simon Goldschmidt wrote:

> If _debug_uart_putc() is called before _debug_uart_init(), the
> ns16550 debug uart driver hangs in a tight loop waiting for the
> tx FIFO to get empty.
> 
> As this can happen via a printf sneaking in before the port calls
> debug_uart_init(), introduce a config option to ignore characters
> before the debug uart is initialized.
> 
> This is done by reading the baudrate divisor and aborting if is zero.
> 
> The Kconfig option is required as reading the baudrate divisor does
> not seem to work for all ns16500 compatibles (which is why the last
> attempt on this has been reverted in 1a67969a99).
> 
> Tested on socfpga_cyclone5_socrates.
> 
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190115/632afd81/attachment.sig>


More information about the U-Boot mailing list