[U-Boot] [PATCH v1 01/21] ARM: DTS: vybrid: Add vf-u-boot.dtsi to set 'u-boot, dm-pre-reloc' in soc

[Tom Rini]

On Wed, Jan 16, 2019 at 08:33:03AM +0100, Lukasz Majewski wrote:
> On Tue, 15 Jan 2019 21:24:31 -0500
> Tom Rini <trini at konsulko.com> wrote:
> 
> > On Tue, Jan 15, 2019 at 08:58:58AM +0100, Lukasz Majewski wrote:
> > > Hi Tom,
> > >   
> > > > On Mon, Jan 14, 2019 at 03:17:20PM +0100, Lukasz Majewski wrote:
> > > >   
> > > > > This property is necessary to allow pinctrl configuration before
> > > > > relocation (uart, DDR pins).
> > > > > 
> > > > > Separate file will facilitate updating vf.dtsi from the Linux
> > > > > kernel.
> > > > > 
> > > > > Signed-off-by: Lukasz Majewski <lukma at denx.de>
> > > > > ---
> > > > > 
> > > > >  arch/arm/dts/vf-u-boot.dtsi | 11 +++++++++++
> > > > >  arch/arm/dts/vf.dtsi        |  1 +
> > > > >  2 files changed, 12 insertions(+)
> > > > >  create mode 100644 arch/arm/dts/vf-u-boot.dtsi    
> > > > 
> > > > We should call the file 'vf610-u-boot.dtsi' which will get it
> > > > automatically included in all vf610 platforms but still allow
> > > > boards that need their own -u-boot.dtsi file to #include
> > > > vf610-u-boot.dtsi 
> > > 
> > > Please forgive me but I do have a hard time to parse the above
> > > sentence.
> > > 
> > > Do you propose to:
> > > 
> > > 1. Rename vf-u-boot.dtsi -> vf610-u-boot.dtsi ?
> > > 
> > > And then just include it in the generic (easily ported from Linux)
> > > vf.dtsi file?
> > > 
> > > or 
> > > 
> > > 2. Shall I rename vf-u-boot.dtsi -> vf610-u-boot.dtsi and then do
> > > not include it into vf.dtsi, but it shall be included in board dts
> > > files (like bk4.dtsi) ?  
> > 
> > Neither exactly.  See scripts/Makefile.lib for the rules that
> > automatically pick up various -u-boot.dtsi suffixed files.  "vf610"
> > will be picked up and "vf" will not.  You do _not_ need include it in
> > other non "-u-boot.dtsi" files. 
> 
> Thanks Tom for sharing this information. I was not aware that such
> *-u-boot.dtsi files are automatically picked for device tree
> compilation.
> 
> > You will likely end up with
> > vf610-bk4-u-boot.dtsi or something to both set stdout-path
> > under /chosen and #include vf610-u-boot.dtsi.
> 
> Why do I need to #include vf610-u-boot.dtsi in the
> vf610-bk4-u-boot.dtsi file as the vf610-u-boot.dtsi is picked
> automatically for the compilation?
> 
> I guess that I shall #include vf610-bk4-u-boot.dtsi explicitly to the
> bk4.dts (as it is not picked up) ?

The rules pick up a single file automatically.  So if you end up with a
board specific -u-boot.dtsi file (to for example set stdout-path or
something else Linux won't take) then it needs to grab the SoC file.
See for example dra7-evm-u-boot.dtsi.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190116/5e0e1a8f/attachment.sig>